1224208 - Decouple autoland and CI results in the ui

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mauro Doglio [:mdoglio]]

Attachment: autoland_results_proposal.jpg

We should display one result for the actual landing on the target repository and eventually a separate result for the CI run when available.

Comment 1

[Mauro Doglio [:mdoglio]]

Attachment: MozReview Request: testing: fix test-autoland-concurrent; r=glob

testing: fix test-autoland-concurrent; r?glob

The changes ntroduced in rev c2620e01e208 made this test fail.

Comment 2

[Mauro Doglio [:mdoglio]]

Attachment: MozReview Request: mozreview: split autoland and treeherder results (bug 1224208); r=dminor

mozreview: split autoland and treeherder results (bug 1224208); r?dminor

This patch splits the results of the autoland `landing` action from the
treeherder job results eventually created as a consequence of that action.

Comment 3

[Mauro Doglio [:mdoglio]]

Attachment: MozReview Request: testing: rename test_autoland_try_concurrent; r=dminor

testing: rename test_autoland_try_concurrent; r?dminor

test_autoland_try is already present in the AutolandTryTest class,
let's rename it to avoid confusion when reading the test results.

Comment 4

[Dan Minor [:dminor]]

Comment on attachment 8693636 [details]
MozReview Request: testing: rename test_autoland_try_concurrent; r=dminor

https://reviewboard.mozilla.org/r/26519/#review23933

Comment 5

[Dan Minor [:dminor]]

Comment on attachment 8693635 [details]
MozReview Request: mozreview: split autoland and treeherder results (bug 1224208); r=dminor

https://reviewboard.mozilla.org/r/26517/#review23937

lgtm

::: pylib/mozreview/mozreview/static/mozreview/css/commits.less
(Diff revision 1)
> -        min-height:32px;

Why are we removing this?

Comment 6

[Mauro Doglio [:mdoglio]]

https://reviewboard.mozilla.org/r/26517/#review23937

> Why are we removing this?

Because now the autoland results box could be smaller than before when the repo doesn't have a treeherder counterpart. https://reviewboard.mozilla.org/r/26513/file/155/ shows exactly that case.

Comment 7

[:glob ✱]

Comment on attachment 8693634 [details]
MozReview Request: testing: fix test-autoland-concurrent; r=glob

https://reviewboard.mozilla.org/r/26515/#review24127

lgtm.  sorry about dropping that class when i refactored.

Comment 8

[Mauro Doglio [:mdoglio]]

Comment on attachment 8693634 [details]
MozReview Request: testing: fix test-autoland-concurrent; r=glob

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26515/diff/1-2/

Comment 9

[Mauro Doglio [:mdoglio]]

Comment on attachment 8693635 [details]
MozReview Request: mozreview: split autoland and treeherder results (bug 1224208); r=dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26517/diff/1-2/

Comment 10

[Mauro Doglio [:mdoglio]]

Comment on attachment 8693636 [details]
MozReview Request: testing: rename test_autoland_try_concurrent; r=dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26519/diff/1-2/