Closed Bug 1224214 Opened 4 years ago Closed 4 years ago

Remove "Use current tab" checkbox from "Set a homepage" setting

Categories

(Firefox for Android :: Settings and Preferences, defect)

35 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 45
Tracking Status
firefox44 + fixed
firefox45 --- verified
b2g-v2.5 --- fixed
fennec 45+ ---

People

(Reporter: Margaret, Assigned: mcomella, Mentored)

References

Details

(Whiteboard: [lang=java])

Attachments

(2 files)

This came up as part of the designs for bug 1210290, but it doesn't depend on us fixing that bug, so we should just remove this on its own.
Blocks: homepage
Anthony, could you upload your current mock-up here?
Flags: needinfo?(alam)
Attached image attachment.png
good call.
Flags: needinfo?(alam)
^ that's the current mock that calls our the users' two options more clearly.

I think if its not too much work, we should look to do this. 

Having no checkbox at all works too, but as some have correctly pointed out, it could be a bit unclear how to switch back to the "default"
Margaret, can you please let us know how much more work it is to get Anthony's latest suggestion in.

If you ask me, I'd go with shipping what we have for now, but if eng can quickly do this, go for it.
Flags: needinfo?(margaret.leibovic)
Sorry I meant, just removing the "use current tab" checkbox.
I'd like to work on this.
(In reply to Barbara Bermes [:barbara] from comment #4)
> Margaret, can you please let us know how much more work it is to get
> Anthony's latest suggestion in.
> 
> If you ask me, I'd go with shipping what we have for now, but if eng can
> quickly do this, go for it.

This latest suggestion shouldn't be too hard.

(In reply to Alex Johnson(:alex_johnson) from comment #6)
> I'd like to work on this.

Go for it!

I talked to mcomella last week about picking this up, so he may also be planning to work on this, but we'd both be happy to help you out.

Just FYI, we want to ship this in Firefox 45, so we'll need to land a patch within the next 3 weeks.
tracking-fennec: --- → 45+
Flags: needinfo?(margaret.leibovic)
Mentor: michael.l.comella
Hey Alex. We're actually in a hurry for this one so I'm going to take it over – sorry! I assigned you to that other bug, but please let me know if you want me to find more bugs for you to tackle!

via irc, it is my understanding that I should land a patch to remove the current checkbox (& uplift it to 44) and land another patch to add the new "Use current tab" button.
Assignee: nobody → michael.l.comella
(In reply to Michael Comella (:mcomella) from comment #8)
> land another patch to add the new "Use current tab" button.

I meant to add the new "Use default homepage" checkbox.
Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret
Attachment #8691075 - Flags: review?(margaret.leibovic)
Comment on attachment 8691075 [details]
MozReview Request: Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret

https://reviewboard.mozilla.org/r/26059/#review23431
Attachment #8691075 - Flags: review?(margaret.leibovic) → review+
I made a follow-up (bug 1227348) for adding the new checkbox.
Comment on attachment 8691075 [details]
MozReview Request: Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret

Approval Request Comment
[Feature/regressing bug #]: feature bug 1195721
[User impact if declined]: Users may have a bad experience with an unintuitive feature. Note that this does not need to be uplifted if bug 1227322 is not uplifted.

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low – we're removing a UI widget from the dialog, which is a few simple code deletions. The code seems well encapsulated so I don't see many issues. Worst case, we try to access a resource (e.g. a View) that isn't there anymore and we crash.

[String/UUID change made/needed]: None
Attachment #8691075 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/4d565d45bb09
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Requesting QE team to test this fix, there will be other bug fixes related to this too that will land in Aurora. I am told that the feature mentioned in bug 1195721 has been moved up to release in 44 instead of 45. Thanks!
Flags: qe-verify+
Comment on attachment 8691075 [details]
MozReview Request: Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret

I am assuming mcomella has done manual testing to ensure the fix looks good. Given that this work is now planned for 44, approving for uplift to Aurora44+
Attachment #8691075 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 45.0a1 (2015-12-06)
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.