1224214 - Remove "Use current tab" checkbox from "Set a homepage" setting

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Margaret Leibovic]

This came up as part of the designs for bug 1210290, but it doesn't depend on us fixing that bug, so we should just remove this on its own.

Comment 1

[:Margaret Leibovic]

Anthony, could you upload your current mock-up here?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: attachment.png

good call.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

^ that's the current mock that calls our the users' two options more clearly.

I think if its not too much work, we should look to do this. 

Having no checkbox at all works too, but as some have correctly pointed out, it could be a bit unclear how to switch back to the "default"

Comment 4

[Barbara Bermes [:barbara] - NI please!]

Margaret, can you please let us know how much more work it is to get Anthony's latest suggestion in.

If you ask me, I'd go with shipping what we have for now, but if eng can quickly do this, go for it.

Comment 5

[Barbara Bermes [:barbara] - NI please!]

Sorry I meant, just removing the "use current tab" checkbox.

Comment 6

[Alex Johnson (:alex_johnson)]

I'd like to work on this.

Comment 7

[:Margaret Leibovic]

(In reply to Barbara Bermes [:barbara] from comment #4)
> Margaret, can you please let us know how much more work it is to get
> Anthony's latest suggestion in.
> 
> If you ask me, I'd go with shipping what we have for now, but if eng can
> quickly do this, go for it.

This latest suggestion shouldn't be too hard.

(In reply to Alex Johnson(:alex_johnson) from comment #6)
> I'd like to work on this.

Go for it!

I talked to mcomella last week about picking this up, so he may also be planning to work on this, but we'd both be happy to help you out.

Just FYI, we want to ship this in Firefox 45, so we'll need to land a patch within the next 3 weeks.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Hey Alex. We're actually in a hurry for this one so I'm going to take it over – sorry! I assigned you to that other bug, but please let me know if you want me to find more bugs for you to tackle!

via irc, it is my understanding that I should land a patch to remove the current checkbox (& uplift it to 44) and land another patch to add the new "Use current tab" button.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #8)
> land another patch to add the new "Use current tab" button.

I meant to add the new "Use default homepage" checkbox.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: MozReview Request: Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret

Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret

Comment 11

[:Margaret Leibovic]

Comment on attachment 8691075 [details]
MozReview Request: Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret

https://reviewboard.mozilla.org/r/26059/#review23431

Comment 12

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/4d565d45bb09c4515b23a9f299666e478b246662
Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret

Comment 13

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

I made a follow-up (bug 1227348) for adding the new checkbox.

Comment 14

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Comment on attachment 8691075 [details]
MozReview Request: Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret

Approval Request Comment
[Feature/regressing bug #]: feature bug 1195721
[User impact if declined]: Users may have a bad experience with an unintuitive feature. Note that this does not need to be uplifted if bug 1227322 is not uplifted.

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low – we're removing a UI widget from the dialog, which is a few simple code deletions. The code seems well encapsulated so I don't see many issues. Worst case, we try to access a resource (e.g. a View) that isn't there anymore and we crash.

[String/UUID change made/needed]: None

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d565d45bb09

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Requesting QE team to test this fix, there will be other bug fixes related to this too that will land in Aurora. I am told that the feature mentioned in bug 1195721 has been moved up to release in 44 instead of 45. Thanks!

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8691075 [details]
MozReview Request: Bug 1224214 - Remove "Set current tab" checkbox from homepage setting. r=margaret

I am assuming mcomella has done manual testing to ensure the fix looks good. Given that this work is now planned for 44, approving for uplift to Aurora44+

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4ce96e71b5c1

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4ce96e71b5c1

Comment 20

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 45.0a1 (2015-12-06)