Closed Bug 1224223 Opened 9 years ago Closed 9 years ago

Remove add-on renaming functionality until we have a better UX.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

Attachments

(2 files)

[gaia] yzen:bug-1224223 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gasolin
: review+
mpotharaju
: approval-gaia-v2.5+
Details | Review
[gaia] yzen:bug-1224223-v2.5 > mozilla-b2g:v2.5
46 bytes, text/x-github-pull-request
Details | Review 
Right now renaming is implemented by swapping an original add-on with a copy and requires a lot of user actions that are very confusing (deleting original, installing copy). Lets get rid of it until it can be done in a more user friendly way.
Attachment #8686642 - Flags: review?(gasolin)
Comment on attachment 8686642 [details] [review]
[gaia] yzen:bug-1224223 > mozilla-b2g:master

looks good
Attachment #8686642 - Flags: review?(gasolin) → review+
https://github.com/mozilla-b2g/gaia/commit/e7855fec8ec7d8b5176f03a50c0041073181532a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks a blocker.
blocking-b2g: --- → 2.5+
Comment on attachment 8686642 [details] [review]
[gaia] yzen:bug-1224223 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
This is needed for bug 1216301.

[User impact] if declined:
Silent add-on notifications will have a flow that allows breaking add-ons.

[Testing completed]:
Unit tests.

[Risk to taking this patch] (and alternatives if risky):
The risk is to the add-on panel settings activity flow, which only shows itself (I believe) in the silent update flow. Right now it is broken, so this patch can't make it much worse. 

[String changes made]: none
Attachment #8686642 - Flags: approval-gaia-v2.5?
Comment on attachment 8686642 [details] [review]
[gaia] yzen:bug-1224223 > mozilla-b2g:master

Approved for 2.5 uplift.

Thanks
Attachment #8686642 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
For 2.5 specific PR.
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: