1224237 - Remove the !baseURL check from ServiceWorkerContainer::Register

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Eddy Bruel [:ejpbruel]]

As per discussion on irc.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Patch to be reviewed.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

To clarify, the check is unneeded as relative script and scopes will just fail at the NS_NewURI() calls if the baseURI is nullptr.  Allowing nullptr baseURI permits us to use serviceWorker.register() with absolute URIs in test frame scripts where there is no document.

Comment 3

[Eddy Bruel [:ejpbruel]]

This patch is simple enough that we can risk landing it without a try push.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc555a3298d3

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bc555a3298d3

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8686638 [details] [diff] [review]
Patch to be reviewed.

Approval Request Comment
[Feature/regressing bug #]: Service workers
[User impact if declined]: This is needed to uplift bug 1223116.
[Describe test coverage new/current, TreeHerder]:  Test in bug 1223116
[Risks and why]: Minimal.  Only service workers.
[String/UUID change made/needed]: None.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8686638 [details] [diff] [review]
Patch to be reviewed.

Aurora44+, seems like it is needed for another uplift related to SW, which is planned for FF44.

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/b2f5153b4455

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b2f5153b4455