Closed Bug 1224237 Opened 4 years ago Closed 4 years ago
Remove the !base
URL check from Service Worker Container::Register
As per discussion on irc.
To clarify, the check is unneeded as relative script and scopes will just fail at the NS_NewURI() calls if the baseURI is nullptr. Allowing nullptr baseURI permits us to use serviceWorker.register() with absolute URIs in test frame scripts where there is no document.
Attachment #8686638 - Flags: review?(bkelly) → review+
This patch is simple enough that we can risk landing it without a try push.
Comment on attachment 8686638 [details] [diff] [review] Patch to be reviewed. Approval Request Comment [Feature/regressing bug #]: Service workers [User impact if declined]: This is needed to uplift bug 1223116. [Describe test coverage new/current, TreeHerder]: Test in bug 1223116 [Risks and why]: Minimal. Only service workers. [String/UUID change made/needed]: None.
Attachment #8686638 - Flags: approval-mozilla-aurora?
Comment on attachment 8686638 [details] [diff] [review] Patch to be reviewed. Aurora44+, seems like it is needed for another uplift related to SW, which is planned for FF44.
Attachment #8686638 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.