Closed Bug 1224237 Opened 8 years ago Closed 8 years ago

Remove the !baseURL check from ServiceWorkerContainer::Register

Categories

(Core :: DOM: Service Workers, defect)

Product:
Core
Component:
DOM: Service Workers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox43 --- wontfix
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: ejpbruel, Assigned: ejpbruel)

References

Details

Attachments

(1 file)

Patch to be reviewed.
906 bytes, patch
bkelly
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
As per discussion on irc.

        Attachment #8686638 -
        Flags: review?(bkelly)

    
    

    
  
To clarify, the check is unneeded as relative script and scopes will just fail at the NS_NewURI() calls if the baseURI is nullptr.  Allowing nullptr baseURI permits us to use serviceWorker.register() with absolute URIs in test frame scripts where there is no document.

        Attachment #8686638 -
        Flags: review?(bkelly) → review+

    
    

    
  
This patch is simple enough that we can risk landing it without a try push.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/bc555a3298d3
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox45:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

    
    

    
  
Comment on attachment 8686638 [details] [diff] [review]
Patch to be reviewed.

Approval Request Comment
[Feature/regressing bug #]: Service workers
[User impact if declined]: This is needed to uplift bug 1223116.
[Describe test coverage new/current, TreeHerder]:  Test in bug 1223116
[Risks and why]: Minimal.  Only service workers.
[String/UUID change made/needed]: None.

        Attachment #8686638 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8686638 [details] [diff] [review]
Patch to be reviewed.

Aurora44+, seems like it is needed for another uplift related to SW, which is planned for FF44.

        Attachment #8686638 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

          You need to log in
          before you can comment on or make changes to this bug.