1224255 - [TV Browser] ("Show password") The underline should be red if the passwords are less than 8 characters in length

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)

Description

[Cynthia Tang [:cynthiatang]]

============== Gaia Information ==============
commit 27bc9412ca607648bc398b25bb1ae25653b2b278
Author: Greg Weng <[e-mail]>
Date:   Thu Nov 12 10:27:47 2015 +0800

For Firefox account, the password must be at least 8 characters

STR: 
 1. Launch Browser
 2. Go to "Sign in to Sync" 
 3. Use your email address to sign in
 4. Select "Show password" 
 5. Enter "asdf" in the password filed.

Expected Result
 - The underline should be red

Actual Result:
 - The underline is blue

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1224255_password_underline_error_notice > mozilla-b2g:master

Comment 2

[Dan Huang[:danhuang]]

Comment on attachment 8689456 [details] [review]
[gaia] danhuang1202:1224255_password_underline_error_notice > mozilla-b2g:master

Hi Sean, please help review. This patch update the password input's underline color to red, when the input is invalid and the 'show password' option is enabled. Thanks.

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8689456 [details] [review]
[gaia] danhuang1202:1224255_password_underline_error_notice > mozilla-b2g:master

Hey Dan,

Thanks for the effort and the underline issue is fixed.
When the password is less then 8 characters, the input field of password is in black color rather then in red. After checking with email field, the color of underline and input field will be in red when the input is invalid.

Shall we change the font color to red when the password is less then 8 characters?

Comment 4

[Dan Huang[:danhuang]]

Comment on attachment 8689456 [details] [review]
[gaia] danhuang1202:1224255_password_underline_error_notice > mozilla-b2g:master

Hi Sean, please help me review again. This patch will set password input text to red when invalid. Thanks.

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8689456 [details] [review]
[gaia] danhuang1202:1224255_password_underline_error_notice > mozilla-b2g:master

LGTM! Thanks for the effort.

Comment 6

[Dan Huang[:danhuang]]

Thanks for the review.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/e46c486d577cf12b1f7255c500a9d4d4bf10b10b

Comment 7

[Dan Huang[:danhuang]]

Comment on attachment 8689456 [details] [review]
[gaia] danhuang1202:1224255_password_underline_error_notice > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1194108 
[User impact] if declined: not align to the UX visual spec
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=9918b58b0f1e6ab68f8b890851889a610da2fb4f
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 8

[Josh Cheng [:josh]]

Comment on attachment 8689456 [details] [review]
[gaia] danhuang1202:1224255_password_underline_error_notice > mozilla-b2g:master

Approve for TV 2.5 Browser

Comment 9

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/887d6a166e1cb75362f2c78565493884e96bf2f0

Comment 10

[Rid Pan]

Verify this issue on the latest build.
The underline shows red color when the passwords are less than 8 characters in length.
[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/a6ecae635719115aa72465efe522fdced3dd1d70
gecko:
https://hg.mozilla.org/mozilla-central/rev/af6356a3e8c56036b74ba097395356d9c6e6c5a3