1224280 - [jsdbg2] wrong warning message when disabling asm.js with allowUnobservedAsmJS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[James Long (:jlongster)]

It appears that if I create a Debugger and set `allowUnobservedAsmJS = true` initially, and then later I set it to `false` to disable it, I get this warning in the console: "TypeError: asm.js type error: Disabled by javascript.options.asmjs in about:config"

Not sure why the warning is different. If I never changed the flag (it default to false) I see a warning more like "disabled by debugger". We should fix this as it's very confusing why it's disabled.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Not sure this is really a hard blocker for bug 1132501.

Comment 2

[James Long (:jlongster)]

I agree, not a hard blocker but really want to fix it asap. It's going to be confusing, but it's ok if the other bug lands first.

Not sure how best to track that. I suppose we can remove the blocker but I'll just make sure this gets worked on.

Comment 3

[Jan de Mooij [:jandem]]

Should be an easy fix.

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Patch

ParseTask::init disabled asm.js manually when we're parsing off-thread, and that triggered the confusing message.

This patch makes asmJSOption an enum class, so that we can distinguish the two cases. It also handles this case in the CompileOptions constructors so we don't need that check in ParseTask::init.

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8687105 [details] [diff] [review]
Patch

Review of attachment 8687105 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent, thanks!

::: js/src/asmjs/AsmJSValidate.cpp
@@ +8283,3 @@
>          return Warn(parser, JSMSG_USE_ASM_TYPE_FAIL, "Disabled by debugger");
>  
> +    MOZ_ASSERT(parser.options().asmJSOption == AsmJSOption::Enabled);

How about a switch (parser.options().asmJSOption)?

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/799834846e7c

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/799834846e7c