Get MarionetteJS Tests Running On Treeherder for Devices

RESOLVED WONTFIX

Status

Firefox OS
Gaia::UI Tests
RESOLVED WONTFIX
2 years ago
a year ago

People

(Reporter: Silne30, Unassigned)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
We need to get devices tests up on Treeherder so that the view pattern stuff can be verified and merged.
(Reporter)

Updated

2 years ago
Blocks: 1145657
(Reporter)

Updated

2 years ago
Flags: needinfo?(jlorenzo)
Running the tests on TaskCluster requires a remote adb connection. Do we have a way to give a remote host and port to the Makefile, like you'd do with BUILDAPP=device[1]?

[1] https://developer.mozilla.org/en-US/Firefox_OS/Automated_testing/Gaia_integration_tests#Running_tests_on_device
Flags: needinfo?(jlorenzo) → needinfo?(jdorlus)
(Reporter)

Comment 2

2 years ago
Hi, Johan. We don't yet. But that feature should be coming with the work that is happening on fxos-device-service. I am not sure how soon that will happen, so maybe we should check 1145657 locally for now to get it checked in?
Flags: needinfo?(jdorlus) → needinfo?(jlorenzo)
Verifying bug 1145657 locally is doable. However, we know that end-to-end tests are subject to breaking changes coming from any part of the stack. Then, I'd prefer not to merge the PR, until we continuously check that this test remains valid.

If we checked it in, people would be able to see it in the code base, and they might think this code runs somewhere, whereas it's dead code. Moreover, if somebody decided to use the views created in 1145657, they might have to actually debug them.

Hence, in order to make the intent clear, I think it's better to leave the code in a PR. It remains publicly available. People will be able to use it, knowing that some changes might be needed.

What do you think?


Apart from that, fxos-device-service was announced to have reached v1.0. Based on the readme, this version enables remote host and port[1]. It was also announced the work to integrate it to MJS will be done during this quarter. Bug 1214285 tracks the work needed for raptor. I couldn't find an equivalent for MJS. Do we have one?

[1] https://github.com/mozilla-b2g/fxos-device-service#post-connectionsport
Flags: needinfo?(jlorenzo) → needinfo?(jdorlus)
The PR from bug 1145657 can run on b2g desktop, no?
(Reporter)

Comment 5

2 years ago
(In reply to Martijn Wargers [:mwargers] (QA) from comment #4)
> The PR from bug 1145657 can run on b2g desktop, no?

Yes. It works on Mulet. I am not sure if B2G Desktop is still being used. When you say on B2G Desktop, are you meaning Mulet?

Running make test-integration runs Mulet only as far as I understand.
Flags: needinfo?(jdorlus)
(Reporter)

Comment 6

2 years ago
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #3)
> Verifying bug 1145657 locally is doable. However, we know that end-to-end
> tests are subject to breaking changes coming from any part of the stack.
> Then, I'd prefer not to merge the PR, until we continuously check that this
> test remains valid.
> 
> If we checked it in, people would be able to see it in the code base, and
> they might think this code runs somewhere, whereas it's dead code. Moreover,
> if somebody decided to use the views created in 1145657, they might have to
> actually debug them.
> 
> Hence, in order to make the intent clear, I think it's better to leave the
> code in a PR. It remains publicly available. People will be able to use it,
> knowing that some changes might be needed.
> 
> What do you think?
> 
> 
> Apart from that, fxos-device-service was announced to have reached v1.0.
> Based on the readme, this version enables remote host and port[1]. It was
> also announced the work to integrate it to MJS will be done during this
> quarter. Bug 1214285 tracks the work needed for raptor. I couldn't find an
> equivalent for MJS. Do we have one?
> 
> [1] https://github.com/mozilla-b2g/fxos-device-service#post-connectionsport

I think that it's a good idea leaving the changes in a PR if you do. I don't know of a tracking bug for integrating MJS with FXOS-Device-Service for the b2g side of things.
Depends on: 1232321
(Reporter)

Comment 7

a year ago
No longer relevant.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.