Closed Bug 1224308 Opened 5 years ago Closed 5 years ago

Remove some Makefile cruft

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

My patch also removes DIST_PROGRAM from a pair of Makefiles. I have no idea what it ever did.
bug 1224308 - Remove some Makefile cruft. r?gps
Attachment #8686729 - Flags: review?(gps)
Comment on attachment 8686729 [details]
MozReview Request: bug 1224308 - Remove some Makefile cruft. r?gps

https://reviewboard.mozilla.org/r/25047/#review22661
Attachment #8686729 - Flags: review?(gps) → review+
So I was wrong about PROGRAMS_DEST, and didn't notice it till I did a try run. Turns out those Makefiles set that because somewhere up the line a moz.build file exports DIST_SUBDIR for them:
https://dxr.mozilla.org/mozilla-central/source/browser/moz.build#30

...so FINAL_TARGET winds up being dist/bin/whatever.

I'll spin off another bug for that.
https://hg.mozilla.org/mozilla-central/rev/eda67eb9f498
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.