1224308 - Remove some Makefile cruft

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

PROGRAMS_DEST defaults to dist/bin, so setting it to that is useless:
https://dxr.mozilla.org/mozilla-central/source/config/makefiles/target_binaries.mk#25

DARWIN_EXE_LDFLAGS doesn't occur anywhere else in the codebase:
https://dxr.mozilla.org/mozilla-central/rev/a8ed7dd831d1969a5a1a8636e63bd93d6aeaf94a/js/src/shell/Makefile.in#9

Comment 1

[(not currently active) Ted Mielczarek]

My patch also removes DIST_PROGRAM from a pair of Makefiles. I have no idea what it ever did.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1224308 - Remove some Makefile cruft. r?gps

bug 1224308 - Remove some Makefile cruft. r?gps

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8686729 [details]
MozReview Request: bug 1224308 - Remove some Makefile cruft. r?gps

https://reviewboard.mozilla.org/r/25047/#review22661

Comment 4

[(not currently active) Ted Mielczarek]

So I was wrong about PROGRAMS_DEST, and didn't notice it till I did a try run. Turns out those Makefiles set that because somewhere up the line a moz.build file exports DIST_SUBDIR for them:
https://dxr.mozilla.org/mozilla-central/source/browser/moz.build#30

...so FINAL_TARGET winds up being dist/bin/whatever.

I'll spin off another bug for that.

Comment 5

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eda67eb9f49878fbd0d67c2a38bdc9af24e51504
bug 1224308 - Remove some Makefile cruft. r=gps

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eda67eb9f498