1224309 - AddonManager should detect shutdown and abort any in-flight installs

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: duringInstall.txt

While testing the telemetry experiment in bug # 1174937, I ran into the following error while I "command + q" while the experiment was being installed. Once I ran into the error mentioned below, the telemetry experiment broke and didn't disable itself. More context available in Bug # 1174937 Comment # 75.

I've also attached the following logs: (the telex messages were added for debugging purposes in the telemetry experiment)
 
- duringInstall.txt (while the experiment was being installed, command +q)
- afterRestart.txt (after command + q, re-launch fx)

1447193127747 addons.xpi-utils WARN Error: XPI database modified after shutdown began (resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:451:17) JS Stack trace: [e-mail]:451:17 < [e-mail]:1398:9 < [e-mail]:2639:7 < _startProvider/AMProviderShutdown/<@AddonManager.jsm:843:21 < [e-mail]:385:5 < _startProvider/[e-mail]:841:16 < Barrier/this.client.addBlocker/promise</[e-mail]:686:23 < Barrier.prototype<[e-mail]:830:7 < Barrier.prototype<[e-mail]:814:28 < AddonManagerInternal.shutdownManager<@AddonManager.jsm:1233:15

STR:

- install the latest fx beta
- once fx is installed, go into about:config and "devtools.chrome.enabled;true"
- open the browser console and change the following prefs:

Services.prefs.setBoolPref("experiments.logging.dump", true);
Services.prefs.setCharPref("experiments.logging.level", "Trace");
Services.prefs.setCharPref("experiments.force-sample-value", ".1");
Services.prefs.setBoolPref("xpinstall.signatures.required", false);

- once you've changed the above prefs, "experiments.manifest.uri;http://www.kamiljozwiak.io/firefox-manifest.json"
- as soon as you change the "experiments.manifest.uri" pref, the installation process will begin instantly so quickly press "command + q"

This is pretty tricky as it's timing based so it might take a few times to reproduce. When reproduced, the experiment will still be enabled and never ended up contacting the server (DataDog).

Comment 1

[Kamil Jozwiak [:kjozwiak]]

Attachment: afterRestart.txt

Comment 2

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.