1224310 - Suggested tiles requires two blocks to stop showing in newtab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[maxim zhilyaev]

Occasionally, a user still needs to block a suggested tile twice before it disappears from newtab page.  The expected behavior is when suggested tiles stop showing after a user blocks it ones.

This is a followup bug from Bug 1204361.

I managed to reproduce it on nightly. Suspect a caching issue.
Assigning to myself for root-cause analysis.

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to maxim zhilyaev from comment #0)
> Occasionally, a user still needs to block a suggested tile twice before it disappears

Clarifying this language slightly -- we seem to be showing *two different suggested tiles* in a row when this happens. At least, that's the case in Paul's screencast http://screencast.com/t/G0mEszAxu8R -- first he's got a "Quartz" suggested tile, and then he x's that out and gets a "The Scene" suggested tile.  (Not sure if this matches maxim's experience when he reproduced this.)

Comment 2

[maxim zhilyaev]

Attachment: updated suggested tiles when suggested tile is blocked

Comment 3

[Marcos Caceres [:marcosc]]

Comment on attachment 8687381 [details] [diff] [review]
updated suggested tiles when suggested tile is blocked

Review of attachment 8687381 [details] [diff] [review]:
-----------------------------------------------------------------

Was this line previously deleted or something? Any idea how this bug came about?

Comment 4

[maxim zhilyaev]

Did not see "double block" behavior when fixing Bug 1204361.
Which is why this was overlooked.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/70bb205d2c85

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/70bb205d2c85

Comment 7

[maxim zhilyaev]

Attachment: v1. aurora patch

Approval Request Comment
[Feature/regressing bug #]:
Bug 1224310 - Suggested tiles requires two blocks to stop showing in newtab
[User impact if declined]:
Irritating need to block suggested tile twice to make it go away
[Describe test coverage new/current, TreeHerder]:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e4b672a0b3c
manual testing
[Risks and why]: 
One liner change - risks are minimal
[String/UUID change made/needed]:
None

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8687978 [details] [diff] [review]
v1. aurora patch

Seems like a good bug to fix, it is annoying if it takes more than one try to remove a suggested tile. Let's uplift to Aurora44.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e7dfc76d2f5f

Comment 10

[Paul Silaghi, QA [:pauly]]

Suggested tiles can be closed now by one click.
Verified fixed 45.0a1 (2015-11-17) Win 7.

Comment 11

[Paul Silaghi, QA [:pauly]]

Question: no matter what I do, I can see only one suggested tile. Is it possible to have more suggested tiles displayed?

Comment 12

[maxim zhilyaev]

Paul,

Do you want to have two different suggested tiles displayed on same newtab page simultaneously?
Or do you want to have different suggested tiles being recommended to you in the same tile?

The former, I do not think can be changed. If it's the latter, you should see a different suggested tile if you load a new page a few times, which would change you history tiles display.

Comment 13

[Paul Silaghi, QA [:pauly]]

(In reply to maxim zhilyaev from comment #12)
> Do you want to have two different suggested tiles displayed on same newtab
> page simultaneously?
Yes
> The former, I do not think can be changed
Ok, considering the current behavior as expected. Thanks

Comment 14

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 44.0a2 (2015-11-19) OS X 10.8.5