Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Make the zoomed view work properly with the C++ APZ enabled

RESOLVED FIXED in Firefox 45



Firefox for Android
Graphics, Panning and Zooming
2 years ago
2 years ago


(Reporter: kats, Assigned: kats)


Firefox 45
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)



(3 attachments)

With the C++ APZ on Fennec the zoomed view doesn't show up properly. Need to fix that up so that it works the same as without C++ APZ. The patches here will build on top of bug 1223296; they're kind of related because they affect the Gesture:SingleTap handler in browser.js, but I wanted to have a separate bug for this.
Created attachment 8687331 [details] [diff] [review]
Part 1 - Ensure that tapping a cluster doesn't send a click to content
Attachment #8687331 - Flags: review?(rbarker)
Created attachment 8687332 [details] [diff] [review]
Part 2 - Send the right coordinates in Gesture:SingleTap

This is the equivalent of what you had to do in the double-tap handler as well.
Attachment #8687332 - Flags: review?(rbarker)
Created attachment 8687334 [details] [diff] [review]
Local hacks to make the zoomedview appear reliably

On regular fennec as well as fennec-apz I find it really hard to make the zoomed view appear. I used this patch locally to remove of the heuristics so that I could trigger it more reliably. I used as my test page. Stashing this patch here in case I need it again later.
Attachment #8687331 - Flags: review?(rbarker) → review+
Attachment #8687332 - Flags: review?(rbarker) → review+

Comment 4

2 years ago
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.