Closed Bug 1224331 Opened 9 years ago Closed 9 years ago

Entering Card view while Keyboard is active in a app will make the app image very large.

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Window Mgmt
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.5 verified, b2g-master verified)

Status:
VERIFIED FIXED
Milestone:
2.6 S1 - 11/20
Tracking Flags:
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: jthomas, Assigned: cwiiis)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [2.6-Daily-Testing][Spark])

Attachments

(5 files)

logcat_20151112_1223.txt
287.70 KB, text/plain
Details
[gaia] Cwiiis:bug1224331-card-view-previews > mozilla-b2g:master
46 bytes, text/x-github-pull-request
etienne
: review+
mpotharaju
: approval-gaia-v2.5+
Details | Review
verified_Flame_master.3gp
2.02 MB, video/3gpp
Details
Flame_v2.5.png
87.82 KB, image/png
Details
logcat_1101.txt
212.94 KB, text/plain
Details 
Description:
If the user is on the sign in page from Email and enters Card view / Task Manager the image on the card will be zoomed and not formatted correctly. 

Repro Steps:
1) Update a Aries to 20151112122058
2) Select Email App
3) Press and hold SHB to enter Card View

Actual:
User is taken to Card View, the format of the Email image on the card is aligned correctly.

Expected:
It is expected that the image representing the Email app will be aligned correctly.

Environmental Variables:
Device: Aries 2.6
BuildID: 20151112122058
Gaia: 27bc9412ca607648bc398b25bb1ae25653b2b278
Gecko: 3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Repro frequency: 5/5
See attached: Logcat & Video
Video: https://youtu.be/m0VhLDz98Bc
Correction regarding my original post for Actual result; I meant that the Email image on the card is NOT aligned correctly.
URL: https://youtu.be/m0VhLDz98Bc
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.5: --- → unaffected
status-b2g-master: --- → affected
Whiteboard: [2.6-Daily-Testing][Spark]
This issue DOES occur on Flame 2.6.
Result: The format of the Email image on the card is aligned correctly.

Environmental Variables:
Device: Flame 2.6 Kk Fullflash (512mb)
BuildID: 20151112030244
Gaia: 27bc9412ca607648bc398b25bb1ae25653b2b278
Gecko: 3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D

----------------------

This issue does NOT occur on the Flame 2.5.
Result: Email sign in image in card view is formatted correctly.

Environmental Variables:
Device: Flame 2.5 Kk Fullflash (512mb)
BuildID: 20151112031246
Gaia: 240088d7a70dae41215ef61dd3fe3487709a4b65
Gecko: e1f0fe73bc84ad2103a5c661bdd15c16a47d4af5
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0


User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0
Flags: needinfo?(jmercado)
Keywords: regression
It has been discovered that this issue is not just unique to the login page of the Email app. The main trigger to repro this issue is having the keyboard active while entering cardview. Additional examples are the following:

 -entering card view will one of the contact fields are selected

 -entering card view while a title is selected in Calendar
Summary: Email sign in page looks very large in Card view → Entering Card view while Keyboard is active in a app will make the app image very large.
Minor issue so not nominating to block, but let's get a window here.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado)
Keywords: regressionwindow-wanted
QA Contact: mmurrell
This issue appears to be caused by changes in Bug 1216523

B2G
Last Working
Environmental Variables:
Device: Flame 2.6
BuildID: 20151110020836
Gaia: f10062acefdf0a0fb67253917ceeb13ebcaa70a7
Gecko: 9b2c15970aa07cc7d38b03e6106c71372624862b
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D

First Broken
Environmental Variables:
Device: Flame 2.6
BuildID: 20151110022434
Gaia: 93ee67c1b886aab107999307cc1fd9177cc1f83c
Gecko: eeb80d0df72ffc3d0d1322aad64d0bfbf6c19d91
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D

Last Working gaia / First Broken gecko - Issue does not occur
Gaia: f10062acefdf0a0fb67253917ceeb13ebcaa70a7
Gecko: eeb80d0df72ffc3d0d1322aad64d0bfbf6c19d91

First Broken gaia / Last Working gecko - Issue does occur
Gaia: 93ee67c1b886aab107999307cc1fd9177cc1f83c
Gecko: 9b2c15970aa07cc7d38b03e6106c71372624862b

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/f10062acefdf0a0fb67253917ceeb13ebcaa70a7...93ee67c1b886aab107999307cc1fd9177cc1f83c
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(jmercado)
Keywords: regressionwindow-wanted
Chris this issue seems to have been caused by the changes for bug 1216523.  Can you please take a look?
Blocks: 1216523
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado) → needinfo?(chrislord.net)
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
Flags: needinfo?(chrislord.net)
Target Milestone: --- → 2.6 S1 - 11/20
Comment on attachment 8688020 [details] [review]
[gaia] Cwiiis:bug1224331-card-view-previews > mozilla-b2g:master

This adds a new event 'cardviewprepare' that gets published when 'cardviewbeforeshow' used to get published, and 'cardviewbeforeshow' is now published after the screen has been rotated and the keyboard hidden.
Attachment #8688020 - Flags: review?(etienne)
Comment on attachment 8688020 [details] [review]
[gaia] Cwiiis:bug1224331-card-view-previews > mozilla-b2g:master

r=me with the comment addressed/discussed
Attachment #8688020 - Flags: review?(etienne) → review+
Merged: https://github.com/mozilla-b2g/gaia/commit/3bbf10dddcce73cdbf411c272d5c8cd2b29edf84
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8688020 [details] [review]
[gaia] Cwiiis:bug1224331-card-view-previews > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Entering the task manager when the keyboard is visible or when in landscape can produce visually unexpected results.
[Testing completed]: Tested manually and covered by unit tests
[Risk to taking this patch] (and alternatives if risky): Low, I think.
[String changes made]: None
Attachment #8688020 - Flags: approval-gaia-v2.5?
Comment on attachment 8688020 [details] [review]
[gaia] Cwiiis:bug1224331-card-view-previews > mozilla-b2g:master

Fixes regression from an approved patch. Approved for 2.5 uplift.
Attachment #8688020 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
This bug has been verified as "pass" on the latest build of Flame master and Aries KK master by the STR in comment 0.

Actual results: Entering Card view while Keyboard is active in email app does not make the app image very large and shows normally in task manager.
See attachment: verified_Flame_master.3gp
Reproduce rate: 0/10


Device: Flame master 512mb (Pass)    
Build ID               20151124150228
Gaia Revision          e63c07af8cc636b9ffac2c20f9b8ad7e7fe2b977
Gaia Date              2015-11-24 03:47:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d9243e369c22ae1df321491a15eeb931ee43f1f5
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151124.183534
Firmware Date          Tue Nov 24 18:35:47 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)   
Build ID               20151125021621
Gaia Revision          37250b125e0db6966875d3b37b117f6d9b76cbc0
Gaia Date              2015-11-24 16:21:36
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/099f695d31326c39595264c34988a0f4b7cbc698
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.012004
Firmware Date          Wed Nov 25 01:20:12 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
status-b2g-master: affected → verified
Hi Chris,

    This bug occurs on the latest Flame v2.5 and Aries KK v2.5 by the STR in comment 0. Could you please help to confirm whether it will uplift request approval to 2.5?

Thank you very much.

--------------------------------------------------------------------
Actual results:  Entering Card view while Keyboard is active in a app will make the Email (or Facebook) app image very large. 
See attachments: Flame_v2.5.png and logcat_1101.txt
Reproduce rate: 6/6


Device: Flame KK 2.5_512mb (affected)
Build ID               20151126113148
Gaia Revision          34ccc2c8f17b87a1fab95a4186b0019ec78c7f75
Gaia Date              2015-11-26 09:44:10
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fbaba398bd98fd1837ef2fd7c13ed8ee69640cfb
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151126.104320
Firmware Date          Thu Nov 26 10:43:29 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (affected)
Build ID               20151126113601
Gaia Revision          34ccc2c8f17b87a1fab95a4186b0019ec78c7f75
Gaia Date              2015-11-26 09:44:10
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fbaba398bd98fd1837ef2fd7c13ed8ee69640cfb
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151126.104443
Firmware Date          Thu Nov 26 10:44:51 UTC 2015
Bootloader             s1
Status: VERIFIED → RESOLVED
Closed: 9 years ago → 9 years ago
status-b2g-v2.5: unaffected → affected
Flags: needinfo?(chrislord.net)
This bug has been verified as "pass" on the latest build of Flame v2.5 and Aries KK v2.5 by the STR in comment 0.

Actual results: Entering Card view while Keyboard is active in Email/Facebook app does not make the app image very large and shows normally in task manager.
Reproduce rate: 0/10


Device: Flame KK 2.5_512mb (Pass)
Build ID               20151130173516
Gaia Revision          391bcad1b3b427f189f4c7f11858fc739574682e
Gaia Date              2015-11-30 15:51:31
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/1a022b4b67446b50f36c098aa425c65782af9066
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151130.164630
Firmware Date          Mon Nov 30 16:46:40 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151130171620
Gaia Revision          391bcad1b3b427f189f4c7f11858fc739574682e
Gaia Date              2015-11-30 15:51:31
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/1a022b4b67446b50f36c098aa425c65782af9066
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151130.164746
Firmware Date          Mon Nov 30 16:47:54 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
status-b2g-v2.5: fixed → verified
Flags: needinfo?(chrislord.net)
See Also: → 1235532
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: