1224395 - Back button arrow has no functionality in Message Settings or in Homescreen Settings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[John Thomas [:Johnt]]

Attachment: logcat_20151112_1528.txt

Description:
If the user attempts to select the back arrow button from either the Message Settings app or Homescreen Settings nothing will happen other than the button dimming after it has been pressed.

Repro Steps:
1) Update a Aries to 20151112122058
2) Select Messages
3) Select Settings (Gear icon)
4) Select Back Arrow Button

[OR]

2) Select Settings > Home Screens
3) Select Change Home Screen
4) Enable Legacy Home screen
5) From Homescreen press and hold a blank space.
6) Select Homescreen Settings
7) Select Back button

Actual:
Back button has not functionality. Becomes temporarily dimmed after being pressed.

Expected:
It is expected that the user will be able to navigate back one page by pressing the back arrow.

Environmental Variables:
Device: Aries 2.6
BuildID: 20151112122058
Gaia: 27bc9412ca607648bc398b25bb1ae25653b2b278
Gecko: 3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Repro frequency: 5/5
See attached: Logcat & Video
Video: https://youtu.be/WxUCoucT344

Comment 1

[John Thomas [:Johnt]]

This issue DOES occur on Flame 2.6
Result: Back button has not functionality.

Environmental Variables:
Device: Flame 2.6 Kk Fullflash 
BuildID: 20151112030244
Gaia: 27bc9412ca607648bc398b25bb1ae25653b2b278
Gecko: 3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

----------------------

This issue does NOT occur on Flame 2.5
Result: User is able to back out successfully using back button arrow.

Environmental Variables:
Device: Flame 2.5
BuildID: 20151109004552
Gaia: cf646c52bb947af28329b0a100df91d1b1f2a907
Gecko: 4eafef5b80f8985c94c4a067f130d37513e1a581
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

[Blocking Requested - why for this release]:

User cannot back out of the message settings without leaving the messages app.

Comment 3

[John Thomas [:Johnt]]

Possibly caused by changes made in Bug 1194525 

Mozilla Inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 2.6
BuildID: 20151110003734
Gaia: cf650aa1521151d5e4ac6d04188f911712271ec1
Gecko: a037109abaee4b38b0149d538631cfe0337eb76b
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

First Broken
Environmental Variables:
Device: Flame 2.6
BuildID: 20151110005734
Gaia: cf650aa1521151d5e4ac6d04188f911712271ec1
Gecko: 2433822aeda2c0958cf2cf6efb5c24128e286a72
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Last Working gaia / First Broken gecko - This issue DOES occur with broken Gecko
Gaia: cf650aa1521151d5e4ac6d04188f911712271ec1
Gecko: 2433822aeda2c0958cf2cf6efb5c24128e286a72

Last Working gecko / First Broken gaia - This issue does NOT occur with broken Gaia
Gecko: a037109abaee4b38b0149d538631cfe0337eb76b
Gaia: cf650aa1521151d5e4ac6d04188f911712271ec1

Mozilla Inbound Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a037109abaee4b38b0149d538631cfe0337eb76b&tochange=2433822aeda2c0958cf2cf6efb5c24128e286a72

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Andre this issue may have been caused by the changes for bug 1194525.  Can you please tak a look.

Comment 5

[Julien Wajsberg [:julienw]]

We just need to add a returnValue for the settings 'configure' activities. Or use window.close instead of postResult.

Comment 6

[André Natal]

Yes, let me take a look.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] andrenatal:settings_webactv > mozilla-b2g:master

Comment 8

[[e-mail]]

Comment on attachment 8687589 [details] [review]
[gaia] andrenatal:settings_webactv > mozilla-b2g:master

Thanks

Comment 9

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/d16011943b20b6d38b072ed93e992e1e9669311f

Comment 10

[Martin Shuman [:Marty]]

This issue is still occurring on the latest Aries and Flame 2.6 Master builds.
Pressing the Back (<) Arrow does not dismiss Message Settings, and the user is unable to return to the Messages app main page.

Environmental Variables:
Device: Aries 2.6
BuildID: 20151117125448
Gaia: 9473dbcbebf4e758a3b73200968efc69071b4312
Gecko: f8b569906e4c257687664227f470e416872d5802
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Environmental Variables:
Device: Flame 2.6
BuildID: 20151117030236
Gaia: 9473dbcbebf4e758a3b73200968efc69071b4312
Gecko: 898c2c656e4b156c323416ef0c859915f3fd2308
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Comment 11

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Andre can you please take a look at this?  This issue still occurs on the most recent Master build with your changes.

Comment 12

[Julien Wajsberg [:julienw]]

Martin, I just want to make sure that you did use a full flash here ?

Comment 13

[Martin Shuman [:Marty]]

Correct, I reproduced this with Full Flash for both Flame and Aries Master.

Comment 14

[André Natal]

I'll still submit a new patch with the approach that Julien suggested, but this one we just landed should work correctly. 

I just did a make reset-gaia [1] with an updated branch on commit b95dd7f969e51f1f4d6b5b7358e4f6f42292f691 [2] and couldn't reproduce the issue neither on message settings and neither on homescreen settings. 

Martin, maybe this patch isn't included into the build you just did in your phone? 

[1] make GAIA_DEV_PIXELS_PER_PX=1.5 GAIA_OPTIMIZE=1 reset-gaia

[2] commit b95dd7f969e51f1f4d6b5b7358e4f6f42292f691
Merge: 0d8289a 41ee6bc
Author: Martijn <[e-mail]>
Date:   Tue Nov 17 19:48:59 2015 +0100

    Merge pull request #33223 from kindersung/bug_1225409_update_locator

    Bug 1225409 - Update a locator in settings/app.py

Comment 15

[André Natal]

(In reply to Martin Shuman [:Marty] from comment #13)
> Correct, I reproduced this with Full Flash for both Flame and Aries Master.

What's the repo you used to build? Or if you just used a pre-built image, where can we see it's changeset to see if the patch is there?

Comment 16

[Julien Wajsberg [:julienw]]

The changesets were all specified in comment 10 :)
And I confirm they're older than the fix.

Comment 17

[Julien Wajsberg [:julienw]]

(6 minutes older :D)

Comment 18

[Adam Alldredge [:AdamA][Inactive]]

This issue is verified as fixed in Aries 2.6 and Flame 2.6.

Environmental Variables:
Device: Aries 2.6 [Full Flash]
Build ID: 20151118151339 [Full Flash]
OTA: 20151118150131
Gaia: cba7e4b86361af31b153cfebaf99900e0b860f7b
Gecko: 1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: Flame 2.6 [Full Flash][512mb]
BuildID: 20151118145644
Gaia: cba7e4b86361af31b153cfebaf99900e0b860f7b
Gecko: 1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Result:
The back button arrow dismisses the settings.

Comment 20

[André Natal]

Comment on attachment 8687589 [details] [review]
[gaia] andrenatal:settings_webactv > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1224395
[User impact] if declined: A number of apps who uses Settings web activities will won't work 
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=07500c773ff38367d5dee370e050af48f22d8886
[Risk to taking this patch] (and alternatives if risky): -
[String changes made]: -

Comment 21

[Mahendra Potharaju [:mahe]]

Andre - Can you please confirm there are no string changes in this patch?

Comment 22

[André Natal]

Mahe, confirmed.

Comment 23

[Mahendra Potharaju [:mahe]]

Comment on attachment 8687589 [details] [review]
[gaia] andrenatal:settings_webactv > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks

Comment 24

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/184523b202608f24e01cda720370de3ee7c5b8c3