1224415 - Cookies disappeared after upgrading

Status: RESOLVED WONTFIX

(Core :: Networking: Cookies, defect)

Description

[Bryan Price]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20151112030238

Steps to reproduce:

Was running Nightly and noticed that I had an update to restart to install.  I was already in Gmail when I did so, and restarted the browser to install the update.  I updated from 10/11 to 10/12.


Actual results:

After the restart, Google wanted me to log back into Gmail.  Email, password, and text message authentication.  I went back to look to see how many cookies I had, and I had a handful (although I had run into bug #1224324, which I have already filed).


Expected results:

I should have been taken into my account in Gmail without requiring password or 2nd factor authentication.  I should have had multitudinous numbers of cookies when I looked at my cookies.

This has happened to some people on the Nightly-Testers mailing list, but by no means all.

Win64 running 64-bit Nightly.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Ethan, we have some reports of cookie loss on upgrading from the Nightly-testers list.  Could this be related to your recent work?

Comment 2

[Karl Thiessen [:kthiessen, he/him]]

I am confirming this bug; I had identical STR, but experienced this both on OS X and Linux.

Comment 3

[Ethan Tseng [:ethan]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #1)
> Ethan, we have some reports of cookie loss on upgrading from the
> Nightly-testers list.  Could this be related to your recent work?

According to the build date (2015/11/12), it might be caused by the patch of bug 1220570.
https://hg.mozilla.org/releases/mozilla-aurora/rev/8fed0d29cde8

I try to explain the whole story as best as I can, so that all of you could help make the best decision about this bug.

I made three changes to cookie database recently.

Aurora version     43                       44
Cookie version      5           6            7
--------------------+-----------+------------+---------+----------
Push date                     10/5         11/1      11/10
Changeset                      (1)          (2)       (3)

Changesets
(1) https://hg.mozilla.org/mozilla-central/rev/558925a1e26c
    Upgrade cookie schema version from 5 to 6 (for a new feature).
    This patch caused bug 1217594 (Cookies are lost when switching recent Nightlies).

(2) https://hg.mozilla.org/releases/mozilla-aurora/rev/168743bc2474
    Upgrade cookie schema version from 6 to 7 (in order to fix bug 1217594).
    But there is a mistake in this patch, which resulted in incorrect table schema of
    cookie version 6. It is tracked by bug 1220570.

(3) https://hg.mozilla.org/releases/mozilla-aurora/rev/8fed0d29cde8
    This patch fixed bug 1220570 and corrected the table schema of cookie version 6.


In short, the cookie table schema is somewhat incorrect during the builds between 11/1 ~ 11/10.
Upgrading from the build in this period to the latest build could cause cookie lost.
I am sorry about this error but I think it's a non-reversible fault (because users' cookie table were already polluted).

In my opinion, we need to make sure upgrading from a build other than this period (11/1 ~ 11/10)
to the latest one does not cause any cookie lost.

What do you think?

Comment 4

[Patrick McManus [:mcmanus]]

this is only related to some non-released builds .. so let's move on