1224427 - [TV Browser] Strange window popped up after pressing "Forgot your password"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: Gray window - Video

Branch: Master
Commit e8c15ae4e5324a210000ee0a869a962aa542009f
Merge: 6676924 5f6b732
Author: Reza Akhavan <[e-mail]>
Date:   Thu Nov 12 16:10:48 2015 -0800

STR:
 1. Launch Browser
 2. Go to "Sign in to Sync" 
 3. Use your email address to sign in
 4. Press "Forgot your password"

Expected Result:
 - No gray window

Actual Result:
 - Strange(Gray) window popped up after pressing "Forgot your password"

Comment 1

[Cynthia Tang [:cynthiatang]]

Attachment: Gray window - Screenshot

Comment 2

[Evelyn Hung]

@Tori, I didn't find a related section on spec. Do we define the follow-up action?

Comment 3

[yifan [:yifan][:yliao]]

Sean, are you available to resolve this bug? Thank you!

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Okay, I can take it!

Comment 5

[Tori Chen [:tori]]

(In reply to Evelyn Hung [:evelyn] from comment #2)
> @Tori, I didn't find a related section on spec. Do we define the follow-up
> action?

I didn't define it in the spec.
I assume this will open the correspond link in browser and lead user to that page. Is that OK?

Comment 6

[Evelyn Hung]

(In reply to Tori Chen [:tori] from comment #5)
> (In reply to Evelyn Hung [:evelyn] from comment #2)
> > @Tori, I didn't find a related section on spec. Do we define the follow-up
> > action?
> 
> I didn't define it in the spec.
> I assume this will open the correspond link in browser and lead user to that
> page. Is that OK?

Sounds good to me. I don't know what the page is, if the page is interactable on TV, then we have no problem. :)

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/TVSystem/master/Bug1224427 > mozilla-b2g:master

Comment 8

[Sean Lee [:seanlee][:weilonge]]

The strange black block is caused by an incorrect size image as background in System dialog, so any system dialog (e.g. Forget password, FxA sign-in) will be affected. In attachment 8692827 [details] [review], I remove the background image and use a translucent color instead.

Comment 9

[Sean Lee [:seanlee][:weilonge]]

Attachment: Screen Shot 2015-11-27 at 16.12.57.png

Hello Tori,

The attachment is the translucent splash shown in the dialog state changing. May I know your comments? Thank you!

Comment 10

[Tori Chen [:tori]]

After offline discussion with Sean we decided to take off the transparent screen for better visual effect.

Comment 11

[Sean Lee [:seanlee][:weilonge]]

Hey Tori, The latest patch will remove the transparent screen. Thank you!

Comment 12

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8692827 [details] [review]
[gaia] weilonge:seanlee/TVSystem/master/Bug1224427 > mozilla-b2g:master

Hey Rex, Could you help to review the patch? Thank you!

Comment 13

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8692827 [details] [review]
[gaia] weilonge:seanlee/TVSystem/master/Bug1224427 > mozilla-b2g:master

Looks good to me.

Comment 14

[Sean Lee [:seanlee][:weilonge]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/1a0265a14aa4806b6d0e0e955b1580e5da827127
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e93dc15bcfecaabc9d0c47bbf245f0fe2eda0024

Comment 15

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8692827 [details] [review]
[gaia] weilonge:seanlee/TVSystem/master/Bug1224427 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1194108
[User impact] if declined: Very weird black block is shown when dialog pop-up
[Testing completed]: Tested on B2G Desktop
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 16

[Josh Cheng [:josh]]

Comment on attachment 8692827 [details] [review]
[gaia] weilonge:seanlee/TVSystem/master/Bug1224427 > mozilla-b2g:master

Approve for TV 2.5

Comment 17

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/349ee3ee44e4e85f13f64902664e7f9c8e36593e

Comment 18

[Rid Pan]

Verify this issue on the latest build.
No gray window pop up after pressing "Forgot your password".
[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/d9faad5c0f14fcd42f920c9104f0638f46a48b2a
gecko:
https://hg.mozilla.org/mozilla-central/rev/789a12291942763bc1e3a89f97e0b82dc1c9d00b