1224436 - Remove enumerator use in ServiceWorkerManager.cpp

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8686984 [details] [diff] [review]
Patch

Review of attachment 8686984 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerManager.cpp
@@ +2093,2 @@
>  
> +    auto& data = iter.Data();

I'd use |nsAutoPtr<PendingReadyPromise>&| instead of |auto&| here because the type is not at all obvious.

Also, |data| is not a good name. Maybe |pendingReadyPromise| instead?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e69fd2e6d44e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e69fd2e6d44e