Closed Bug 1224478 Opened 7 years ago Closed 7 years ago

Replace do_check_* calls with their Assert.jsm equivalents in PSM xpcshell tests

Categories

(Core :: Security: PSM, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

Attachments

(1 file, 1 obsolete file)

The do_check_* methods have been deprecated for a while: https://developer.mozilla.org/en-US/docs/Mozilla/QA/Writing_xpcshell-based_unit_tests#Assertions_and_logging

Moreover, all the do_check_* methods do now is call the equivalent Assert.jsm methods: https://hg.mozilla.org/mozilla-central/annotate/397c69fa1677/testing/xpcshell/head.js#l863

There's no need for this indirection.
Bug 1224478 - Replace do_check_* calls with their Assert.jsm equivalents in PSM xpcshell tests.

Also replaces if-do_throw() blocks with equivalent Assert.jsm method calls.
Attachment #8687774 - Flags: review?(dkeeler)
Comment on attachment 8687774 [details]
MozReview Request: Bug 1224478 - Replace do_check_* calls with their Assert.jsm equivalents in PSM xpcshell tests.

https://reviewboard.mozilla.org/r/25153/#review22749

Great - thanks!

::: security/manager/ssl/tests/unit/test_sts_preloadlist_perwindowpb.js:67
(Diff revision 1)
>                                           "notsts.nonexistent.mozilla.com.", 0));

nit: indentation
+ Fix indentation nit
Attachment #8687774 - Attachment is obsolete: true
Attachment #8688269 - Flags: review+
Thanks for the review.

(Try push is in comment 2).
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3df44184a432
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.