Closed
Bug 1224503
Opened 9 years ago
Closed 9 years ago
[Music]The search list will not update.
Categories
(Firefox OS Graveyard :: Gaia::Music, defect, P1)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)
VERIFIED
FIXED
blocking-b2g | 2.5+ |
People
(Reporter: wangxin, Assigned: wilsonpage)
References
Details
(Keywords: regression, Whiteboard: [NGA Only])
Attachments
(2 files)
[1.Description]: [Aries v2.5&v2.6][Flame v2.5&v2.6][Music]When user searches music with one keyword in Music home view or Playlist view, then tries another keywords, the search result will not update. See video:"Aries_v2.6.3GP" See log:"logcat_0536.txt" Found Time:05:36 [2.Testing Steps]: Precondition: There are some music files on device. 1. Launch Music. 2. In Music home view or Playlists view, scroll down to invoke search bar. 3. Input a keyword which matched with some songs(e.g "a"). 4. After the search list has been displayed completely, input another keywords(make sure this keywords does not match with any songs. e.g "dhjk"). 5. Observe the search list. [3.Expected Result]: 5. The prompt words "No music found" should display [4.Actual Result]: 5. The search list is same as step 3. [5.Reproduction build]: Flame KK v2.6 512mb (master) (Affected) Build ID 20151112150206 Gaia Revision 27bc9412ca607648bc398b25bb1ae25653b2b278 Gaia Date 2015-11-12 02:27:47 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/3cc3b1968524248450c465c4ea2ee5596ffa65f2 Gecko Version 45.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151112.183236 Firmware Date Thu Nov 12 18:32:49 EST 2015 Firmware Version V18D V4 Bootloader L1TC000118D0 Flame kk v2.5 512mb (Affected) Build ID 20151109004552 Gaia Revision cf646c52bb947af28329b0a100df91d1b1f2a907 Gaia Date 2015-11-09 02:55:50 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581 Gecko Version 44.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151109.041411 Firmware Date Mon Nov 9 04:14:26 EST 2015 Firmware Version V18D V4 Bootloader L1TC000118D0 Aries KK v2.6 (master) (Affected) Build ID 20151112120735 Gaia Revision 27bc9412ca607648bc398b25bb1ae25653b2b278 Gaia Date 2015-11-12 02:27:47 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/3cc3b1968524248450c465c4ea2ee5596ffa65f2 Gecko Version 45.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151112.112635 Firmware Date Thu Nov 12 11:26:43 UTC 2015 Bootloader s1 Aries KK v2.5 (Affected) Build ID 20151110094357 Gaia Revision 07baf613699fa6225359c7f04825c5caeb71d424 Gaia Date 2015-11-09 21:32:50 Gecko Revision http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e14287b00a514a15418dfaa89287030c588ad19d Gecko Version 44.0a2 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151110.090331 Firmware Date Tue Nov 10 09:03:39 UTC 2015 Bootloader s1 [6.Reproduction Frequency]: Always Recurrence,5/5 [7.TCID]: Free Test
Comment 2•9 years ago
|
||
This looks like a gaia-fast-list issue: 17:32:20.151 TypeError: image is undefined gaia-fast-list.js:983:1
Comment 3•9 years ago
|
||
Pretty sure this broke from bug 1217789, which updated a lot of stuff in gaia-fast-list. This has taken us over two weeks to discover. We should be making minor tweaks to fix edge cases now, not handling major fallout like this. I know our tests aren't great here yet, but even so, we shouldn't be breaking this hard. From the error log, it seems like this is a bug in gaia-fast-list, which suggests to me that we need better coverage there. We should also be covering our asses with better tests in the music app itself. At the moment, I think we're *less* stable than OGA Music before we had decent automated tests. If we can't ensure with reasonable confidence that our code actually works and will remain so while we change other areas, then the only way forward I can see is to back out NGA Music for 2.5.
Blocks: 1217789
Comment 4•9 years ago
|
||
Yes the test should be fixed to reproduce the problem so we can catch it. :-/
Comment 5•9 years ago
|
||
Note that this seems to work for me in the albums, artists, and songs views, and sometimes manages to work in the tiles view. But it usually fails the first few times in tiles view. Maybe it has something to do with how we're populating the search results?
Comment 6•9 years ago
|
||
Wilson, Please get this fixed asap. Making it a P1 Thanks Hema
blocking-b2g: --- → 2.5+
Priority: -- → P1
Updated•9 years ago
|
Assignee: nobody → wilsonpage
Comment 7•9 years ago
|
||
Is regression window still needed since cause has been identified?
Flags: needinfo?(squibblyflabbetydoo)
Comment 8•9 years ago
|
||
It would be nice if you could double-check to make sure I didn't make a mistake. Thanks!
Flags: needinfo?(squibblyflabbetydoo)
Comment 9•9 years ago
|
||
I think I've narrowed this down to determine what's causing this issue to happen in the Home and Playlists tabs. So, in both of those tabs, our search query actually performs 3 separate queries: songs, artists and albums. In order to get something on-screen as quickly as possible when searching, we call `setResults()` on the <gaia-fast-list> after each of those 3 queries returns. For example, if I search for "foo", `setResults()` will get called 3 times on the <gaia-fast-list>: 1.) setResults([songs-matching-foo]) 2.) setResults([songs-matching-foo, artists-matching-foo]) 3.) setResults([songs-matching-foo, artists-matching-foo, albums-matching-foo]) Somehow, this seems to be causing <gaia-fast-list> to break and cause this bug. This points to a possible race condition where calling `setResults()` at a certain time will cause the breakage. If I change the Music app to instead wait for all 3 queries to complete before calling `setResults()` just *once* per-search, this bug doesn't happen. This also explains why this bug doesn't happen for any of the other tabs since they only call `setResults()` once per-search. This doesn't seem to be a proper fix though because it seems like we'd just be masking the real issue which lies within <gaia-fast-list>.
Flags: needinfo?(jdarcangelo)
Updated•9 years ago
|
QA Contact: jthomas
Comment 10•9 years ago
|
||
Setting qawanted to confirm this issue is a regression from 2.2 before we go on.
Keywords: qawanted
Comment 11•9 years ago
|
||
This does appear to be a regression. I am not able to reproduce the issue on Flame 2.2 Result: After searching a song name and then erasing that search term followed by inserting an invalid song or artist name the search query will update accordingly with no results. Environmental Variables: Device: Flame 2.2 BuildID: 20151113032509 Gaia: 885647d92208fb67574ced44004ab2f29d23cb45 Gecko: e772f343b736 Gonk: bd9cb3af2a0354577a6903917bc826489050b40d Version: 37.0 (2.2) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 Note: I am currently looking into the window on this issue. Unfortunately the repro rate is very inconsistent. My best chance of reproducing the issue on a broken build is to reflash the device.
Updated•9 years ago
|
Comment 12•9 years ago
|
||
(In reply to John Thomas [:Johnt] from comment #11) > This does appear to be a regression. I am not able to reproduce the issue on > Flame 2.2 > That's because the bug is specific to NGA.
Updated•9 years ago
|
Whiteboard: [NGA Only]
Assignee | ||
Updated•9 years ago
|
Comment 13•9 years ago
|
||
Referencing my note in Comment 11, I am having a very difficult time trying to get a solid repro on this issue. Sometimes the issue will not occur until about the 4th or 5th time reflashing. Sometimes more. If anyone is able to find a more consistent repro please feel to attempt. Unassigning as my results are very inconsistent.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmercado)
QA Contact: jthomas
Assignee | ||
Comment 14•9 years ago
|
||
This should be fixed once bug 1219250 lands.
Updated•9 years ago
|
QA Contact: sleedavid
Updated•9 years ago
|
Flags: needinfo?(jmercado)
Comment 15•9 years ago
|
||
CENTRAL: NO REPRO: LW Device: Flame 2.6 BuildID: 20151031172152 Gaia: 91cac94948094cfdcd00cba5c6483e27e80cb3b0 Gecko: 96377bdbcdf3e444a22aeaa677da696243b00d98 REPRO: FB Device: Flame 2.6 BuildID: 20151102025005 Gaia: bfcf8e9bfa7ba264c5f8bc865ce8a435f9b134cb Gecko: b28ff18cfcdc507c675ae59ae872cd64e89fcdc5 BTG INBOUND: NO REPRO: LW Environmental Variables: Device: Flame 2.6 BuildID: 20151030192729 Gaia: 91cac94948094cfdcd00cba5c6483e27e80cb3b0 Gecko: 3eaedda79e46530dc03b17bbaea52a2248aefe23 Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a Version: 45.0a1 (2.6) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0 REPRO: FB Environmental Variables: Device: Flame 2.6 BuildID: 20151031120755 Gaia: 717ee46c64fde7d69a1146f3c54e95b2ef20e706 Gecko: d9bfbd50c917e7f432a4a8cb12a21dca0b96cc0a Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a Version: 45.0a1 (2.6) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0 LWGaiaFBGecko: No REPRO: LW Device: Flame 2.6 BuildID: 20151031120755 Gaia: 91cac94948094cfdcd00cba5c6483e27e80cb3b0 Gecko: d9bfbd50c917e7f432a4a8cb12a21dca0b96cc0a FBGaiaLWGecko: REPRO FB Device: Flame 2.6 BuildID: 20151030192729 Gaia: 717ee46c64fde7d69a1146f3c54e95b2ef20e706 Gecko: 3eaedda79e46530dc03b17bbaea52a2248aefe23 PushLog: https://github.com/mozilla-b2g/gaia/compare/91cac94948094cfdcd00cba5c6483e27e80cb3b0...717ee46c64fde7d69a1146f3c54e95b2ef20e706 This issue may be caused by BUG 1217789 https://github.com/mozilla-b2g/gaia/commit/2f91717b3fa570264eb546b238d1d1cd5196db50
Comment 16•9 years ago
|
||
Jim was correct that the changes for bug 1217789 seem to have caused this issue. Justin, Wilson says this will be fixed by bug 1219250 when it lands, but if it's not can you please take a look?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado) → needinfo?(jdarcangelo)
Assignee | ||
Comment 17•9 years ago
|
||
Fixed by bug 1219250.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 18•9 years ago
|
||
(In reply to Jayme Mercado [:JMercado] from comment #16) > Jim was correct that the changes for bug 1217789 seem to have caused this > issue. Justin, Wilson says this will be fixed by bug 1219250 when it lands, > but if it's not can you please take a look? I just re-checked this on master with the patch for Bug 1219250 landed and it appears to be working now.
Flags: needinfo?(jdarcangelo)
Reporter | ||
Comment 19•9 years ago
|
||
This bug has been verified as pass on latest Flame master and Aries KK master by STR on comment 0. Rate:0/10 Actual result The searchlist update timely. Device info: Flame master 512M(Pass) Build ID 20151119224634 Gaia Revision 94a821b49f4dca3f9321cd80e13c44c4a6696952 Gaia Date 2015-11-19 15:35:33 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/cc325db44f6f8a58604d60b746c140e73f3d8216 Gecko Version 45.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151119.220436 Firmware Date Thu Nov 19 22:04:46 UTC 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Aries KK master(Pass): Build ID 20151120061630 Gaia Revision 94a821b49f4dca3f9321cd80e13c44c4a6696952 Gaia Date 2015-11-19 15:35:33 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/3835b568092ae3b71adc931d24928670ad7141a7 Gecko Version 45.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151120.052332 Firmware Date Fri Nov 20 05:23:39 UTC 2015 Bootloader s1
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
Reporter | ||
Comment 20•9 years ago
|
||
This bug has been verified as pass on latest Flame v2.5 and Aries KK v2.5 by STR on comment 0. Rate:0/10 Actual result The searchlist update timely. Flame v2.5(pass): Build ID 20151126113148 Gaia Revision 34ccc2c8f17b87a1fab95a4186b0019ec78c7f75 Gaia Date 2015-11-26 09:44:10 Gecko Revision http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fbaba398bd98fd1837ef2fd7c13ed8ee69640cfb Gecko Version 44.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151126.104320 Firmware Date Thu Nov 26 10:43:29 UTC 2015 Bootloader L1TC000118D0 Aries KK v2.5(pass): Build ID 20151126113601 Gaia Revision 34ccc2c8f17b87a1fab95a4186b0019ec78c7f75 Gaia Date 2015-11-26 09:44:10 Gecko Revision http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fbaba398bd98fd1837ef2fd7c13ed8ee69640cfb Gecko Version 44.0a2 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151126.104443 Firmware Date Thu Nov 26 10:44:51 UTC 2015 Bootloader s1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•