1224508 - [PackagedAppService] The resource callback key (URL path) shouldn't contain URI reference.

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Henry Chang [:hchang]]

As title. That is, [1] should be GetSpecIgnoringRef.

[1] https://hg.mozilla.org/mozilla-central/file/tip/netwerk/protocol/http/PackagedAppService.cpp#l750

Comment 1

[Henry Chang [:hchang]]

Attachment: 0001-Bug-1224508-Use-URI-path-without-reference-as-the-ca.patch

Comment 2

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=81a21da2a776

Comment 3

[Henry Chang [:hchang]]

Comment on attachment 8687120 [details] [diff] [review]
0001-Bug-1224508-Use-URI-path-without-reference-as-the-ca.patch

Hi Valentin,

The patch is to use the URI path with no ref as the callback key. A test case is also added. Could you please review this patch? Thanks!

Comment 5

[Valentin Gosu [:valentin]]

Comment on attachment 8687120 [details] [diff] [review]
0001-Bug-1224508-Use-URI-path-without-reference-as-the-ca.patch

Review of attachment 8687120 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=me

Comment 6

[Henry Chang [:hchang]]

Thanks you Valentin!

(In reply to Valentin Gosu [:valentin] from comment #5)
> Comment on attachment 8687120 [details] [diff] [review]
> 0001-Bug-1224508-Use-URI-path-without-reference-as-the-ca.patch
> 
> Review of attachment 8687120 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good. r=me

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/073f06cb5140

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/073f06cb5140