1224523 - Deprecate API for button toasts

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Bug 1157526 replaced all button toasts with a Snackbar. Now we can deprecate the button-part of the API.

Additionally bug 1216051 is filed about deprecating the whole toast API (in discussion).

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1224523 - (Part 1) Deprecate and limit access to button toast methods from within Java. r?mcomella

Bug 1224523 - (Part 1) Deprecate and limit access to button toast methods from within Java. r?mcomella

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1224523 - (Part 2) Log deprecation error if button toast JS API is used. r?mcomella

Bug 1224523 - (Part 2) Log deprecation error if button toast JS API is used. r?mcomella

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8687269 [details]
MozReview Request: Bug 1224523 - (Part 1) Deprecate and limit access to button toast methods from within Java. r?mcomella

https://reviewboard.mozilla.org/r/25165/#review22693

::: mobile/android/base/GeckoApp.java:896
(Diff revision 1)
> +    private void showButtonToast(final String message, final String duration,

Add javadoc to explain an alternative to this method, as per [1](http://stackoverflow.com/a/9031854).

::: mobile/android/base/GeckoApp.java:905
(Diff revision 1)
> +                    ViewStub toastStub = (ViewStub) findViewById(R.id.toast_stub);

Nice optimization!

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8687270 [details]
MozReview Request: Bug 1224523 - (Part 2) Log deprecation error if button toast JS API is used. r?mcomella

https://reviewboard.mozilla.org/r/25167/#review22695

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

I'll hold this back. It looks like we are going to replace all toasts in bug 1224521. Instead of just deprecating button toasts we could deprecate the whole API (More in bug 1224523).

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> (More in bug 1224523).

This should be bug 1216051.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

We are going to deprecate the toast API and delegate calls to create snackbars (bug 1216051).