1224540 - [DSDS] The SIM string is almost invisible end in the wrong position in the incoming call container

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: Screenshot of the issue

As per title, see the attached screenshot.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1224540-incoming-container-sim > mozilla-b2g:master

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8687159 [details] [review]
[gaia] gabrielesvelto:bug-1224540-incoming-container-sim > mozilla-b2g:master

Simple fix for this papercut, it seems that when the callscreen was restyled after v1.3 we forgot to adjust the SIM indicator in the incoming call container.

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: Screenshot of the callscreen with the fix applied

Comment 4

[Tamara Hills [:thills]]

Attachment: incoming.png

Hi Gabriele,

When there is just a contact number and no contact name, the Sim # seems offset a little bit.

Thanks,
-tamara

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

You're right, nice catch. I think this might be due to the fact that the number container is different when the additional info is showed and when it's not. Once I will be done with all this cleanups I swear I'll refactor this code so that we don't need all this magic CSS covering every single corner case to get the correct layout :(

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8687159 [details] [review]
[gaia] gabrielesvelto:bug-1224540-incoming-container-sim > mozilla-b2g:master

Clearing the review flag for now.

Comment 7

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8687159 [details] [review]
[gaia] gabrielesvelto:bug-1224540-incoming-container-sim > mozilla-b2g:master

I've addressed the issue and pushed an additional patch on top of the previous one. Of course this required yet another selector...

Comment 8

[Tamara Hills [:thills]]

Comment on attachment 8687159 [details] [review]
[gaia] gabrielesvelto:bug-1224540-incoming-container-sim > mozilla-b2g:master

Hi Gabriele,

Thanks, it looks good now.  That did the trick.

-tamara

Comment 9

[Gabriele Svelto [:gsvelto] (PTO)]

Merged to gaia/master 2e97f49e03878c9021f893a878283b7c34e76eaf

https://github.com/mozilla-b2g/gaia/commit/2e97f49e03878c9021f893a878283b7c34e76eaf

Comment 10

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8687159 [details] [review]
[gaia] gabrielesvelto:bug-1224540-incoming-container-sim > mozilla-b2g:master

Requestion approval in the name of polish, this is a small, low-risk fix that solves a long-standing visual problem.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Unclear, possibly something related to the 2.0 visual overhaul
[User impact] if declined: The SIM indicator in the incoming call box is almost invisible, see attachment 8687157 [details]
[Testing completed]: Tested on a device and within the emulator
[Risk to taking this patch] (and alternatives if risky): Practically none, this is only a small CSS change
[String changes made]: None

Comment 11

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.6(master) and Aries KK 2.6(master) by the STR in comment 0.

Actual results:  The SIM indicator is visible in the incoming call container.
See attachment: verified_Flame_v2.6.png
Reproduce rate: 0/10


Device: Flame 2.6(master) 512mb (Pass)
Build ID               20151124013632
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005539
Firmware Date          Tue Nov 24 00:55:49 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.6(master) (Pass)
Build ID               20151124014704
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005529
Firmware Date          Tue Nov 24 00:55:36 UTC 2015
Bootloader             s1

Comment 12

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.6.png

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK master by the STR in comment 0.

Actual results:  The SIM indicator is visible in the incoming call container.
See attachment: verified_Flame_v2.6.png
Reproduce rate: 0/10


Device: Flame master(2.6) 512mb (Pass)
Build ID               20151124013632
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005539
Firmware Date          Tue Nov 24 00:55:49 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 14

[Mahendra Potharaju [:mahe]]

Comment on attachment 8687159 [details] [review]
[gaia] gabrielesvelto:bug-1224540-incoming-container-sim > mozilla-b2g:master

Paper cut. Not a must on 2.5. Reducing uplifts to stabilize 2.5 for TV. 

Thanks