1224542 - Homescreen exits edit mode after edit/remove dialogs for pinned sites/bookmarks are shown

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

This is a regression caused by bug 1221349 - because the homescreen's visibility changes when the web activity window is opened, it exits edit mode. I guess we need to track if our visibility was changed due to a web activity (or find a different way of tracking when the phone is locked).

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1224542-homescreen-exits-edit-on-mozactivity > mozilla-b2g:master

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8687266 [details] [review]
[gaia] Cwiiis:bug1224542-homescreen-exits-edit-on-mozactivity > mozilla-b2g:master

Fix this by re-entering edit mode when the activity finishes.

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8687266 [details] [review]
[gaia] Cwiiis:bug1224542-homescreen-exits-edit-on-mozactivity > mozilla-b2g:master

Moving review to Michael, Alberto and Guillaume are on PTO.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8687266 [details] [review]
[gaia] Cwiiis:bug1224542-homescreen-exits-edit-on-mozactivity > mozilla-b2g:master

works good, code good

Comment 5

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/584c9343c302142111344a2843cca42ef9d2d6b3

Comment 6

[Chris Lord [:cwiiis]]

Comment on attachment 8687266 [details] [review]
[gaia] Cwiiis:bug1224542-homescreen-exits-edit-on-mozactivity > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Needs to be uplifted in conjunction with bug 1221349. Low impact if both or neither are uplifted, but will ease uplift of higher impact bugs.
[Testing completed]: Manual testing completed and automated unit testing.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None.

Comment 7

[Mahendra Potharaju [:mahe]]

Please retest bug 1221349 with this regression patch as well. Can approve to uplift for 2.5

Thanks

Comment 8

[Sxean Lee-David [:sxean]]

When attempted to apply both patches per to a 2.5 build the homescreen did not function. 

Chris can you make us a test build with both patches applied to make sure there were no
errors on our side. 

thank you.

Comment 9

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I helped Sxean with this and when both patches were applied no icons showed up on the home screen, but it could still be switched between the left and right screens. If you could provide a build with both patches applied Chris (we normally only apply one patch at a time) for testing that would be ideal.

Comment 10

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame master and Aries KK master.

STR:
1.Pin sites to homscreen.
2.Long tap the pinned site to enter edit mode, remove/edit the site or cancel remove/edit.

Actual results: Homescreen doesn't exit the edit mode after the edit/remove dialogs for pinned sites are shown.
See attachment: verified_Aries_master.3gp
Reproduce rate: 0/10


Device: Flame master 512mb (Pass)    
Build ID               20151124150228
Gaia Revision          e63c07af8cc636b9ffac2c20f9b8ad7e7fe2b977
Gaia Date              2015-11-24 03:47:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d9243e369c22ae1df321491a15eeb931ee43f1f5
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151124.183534
Firmware Date          Tue Nov 24 18:35:47 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)   
Build ID               20151125021621
Gaia Revision          37250b125e0db6966875d3b37b117f6d9b76cbc0
Gaia Date              2015-11-24 16:21:36
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/099f695d31326c39595264c34988a0f4b7cbc698
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.012004
Firmware Date          Wed Nov 25 01:20:12 UTC 2015
Bootloader             s1

Note: Leaving keyword "verifyme" for v2.5 uplift/verification.

Comment 11

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_master.3gp

Comment 12

[Chris Lord [:cwiiis]]

Attachment: Uplift bug 1221349 and bug 1224542

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Homescreen can remain in edit mode when it shouldn't
[Testing completed]: Patches on master for a long time now, also automated unit testing.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None.

Comment 13

[Chris Lord [:cwiiis]]

Note; the pull request for approval here was just a straight cherry-pick - there were no merge conflicts and it worked fine when I tested it. I guess something went awry during the uplift process, or something has been uplifted in the interim that this patch depended on.

Comment 14

[Sxean Lee-David [:sxean]]

No REPRO per these builds: 

RESULT: When go to pin a website it is readily available for editing, and unpinning. 

Environmental Variables:
Device: Aries 2.6
BuildID: 20151209121803
Gaia: 961528f4391668bc89ec0be14fa367cea099b588
Gecko: 319be5e7ce3061c7c16f24d750b6dacdbcac4c35
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Environmental Variables:
Device: Aries 2.5
BuildID: 20151209171644
Gaia: 7ca639a7bb0bacf27f548841c52617bfc0e3b21f
Gecko: a35e8eb98969970d1af28b265bf99a9edd11e9c2
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 44.0a2 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.6
BuildID: 20151209030343
Gaia: 961528f4391668bc89ec0be14fa367cea099b588
Gecko: 319be5e7ce3061c7c16f24d750b6dacdbcac4c35
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Comment 15

[Shally Li（leave from Mozilla）]

Per comment 14, this bug no longer occurs on latest Flame v2.5 and Aries KK v2.5, so clear "verifyme" keyword. 
If someone can repro it again, please add "verifyme" keyword or reopen this bug, thanks.


Device: Flame v2.5_512mb user (no repro)
Build ID               20151209170211
Gaia Revision          7ca639a7bb0bacf27f548841c52617bfc0e3b21f
Gaia Date              2015-12-09 14:07:01
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a35e8eb98969970d1af28b265bf99a9edd11e9c2
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151209.161633
Firmware Date          Wed Dec  9 16:16:42 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 16

[Mahendra Potharaju [:mahe]]

Comment on attachment 8695858 [details] [review]
Uplift bug 1221349 and bug 1224542

Limiting 2.5 only to TV patches. Foxfooders getting updates from master/b2g-ota branch. Removing the uplift nomination.

Also, this issue is not reproduced on 2.5 any longer. 

Thank you