Closed Bug 1224546 Opened 10 years ago Closed 10 years ago

Fix emulator branch names

Categories

(Firefox OS Graveyard :: Emulator, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S2 - 12/4

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Details

Attachments

(1 file)

Some of the branches we pull for emulator have meaningless names ('b2g-emu', 'emu-fix'). We should clean up the naming.
Attached file Github pull request
I didn't change any of the branches. I just added them under new names. I left the old branches in place for now, so we can checkout older versions as well.
Attachment #8687167 - Flags: review?(jgomez)
Attachment #8687167 - Flags: feedback?(echen)
Attachment #8687167 - Flags: feedback?(echen) → feedback+
Hi Juan, can you please take a look at this pull request and the one in bug 1224613? Thanks!
Flags: needinfo?(jgomez)
Comment on attachment 8687167 [details] [review] Github pull request Hi Thomas, Sorry for the late review! I had an intense week at MTV :) I see that you have renamed: b2g-4.0.4_r2.1-emu-fix to b2g-ics. Can we at least call it: b2g-4.0.4_r2.1 , so we don't loose information about what was the initial branch.
Flags: needinfo?(jgomez)
Attachment #8687167 - Flags: review?(jgomez) → review+
(In reply to Juan Gomez [:_AtilA_] (CEST) from comment #3) > Comment on attachment 8687167 [details] [review] > Github pull request > > Hi Thomas, > Sorry for the late review! I had an intense week at MTV :) Oh, I see! :) > I see that you have renamed: b2g-4.0.4_r2.1-emu-fix to b2g-ics. Can we at > least call it: b2g-4.0.4_r2.1 , so we don't loose information about what was > the initial branch. I think the original name is a misnomer, because b2g-4.0.4_r2.1-emu-fix isn't actually based on 4.0.4_r2.1. The tag for 4.0.4_r2.1 is in it's history but ~100 commits away. So without a direct AOSP-based ancestor I called it 'b2g-ics'.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
Depends on: 1255319
No longer depends on: 1255319
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: