1224556 - Default fallback icon for rooms with no context is no longer displayed

Status: VERIFIED FIXED

(Hello (Loop) :: General, defect, P1)

Description

[Mark Banner (:standard8)]

Since bug 1222028 landed, we no longer see the fallback icon if a room has no context associated with it.

I have a patch coming up to fix this.

Comment 1

[Mark Banner (:standard8)]

Attachment: Default fallback icon for Loop's rooms with no context is no longer displayed.

This fixes it - if the default icon is displayed, then there's no link, so we need to account for that.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8687221 [details] [diff] [review]
Default fallback icon for Loop's rooms with no context is no longer displayed.

Review of attachment 8687221 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, thanks! I let that slip through :(

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/647f70a15615

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/647f70a15615

Comment 5

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an older Nightly (2015-11-12), verified that the issue is fixed across platforms (Windows 7 64-bit, Mac OS X 10.11.1 and Ubuntu 14.04 32-bit) using latest Nightly 45.0a1.