1224570 - [Service Workers Panel] Service Workers panel fails to show registered service workers after restart

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Oleg Zasypkin [:azasypkin]]

Here is what I see in the logcat when I try to open Service Workers panel after restart:

I/Gecko   (  208): XXX FIXME : Dispatch a mozIACChromeEvent: inter-app-comm-permission
I/Gecko   (  208): XXX FIXME : Dispatch a mozIACContentEvent: inter-app-comm-permission
I/Gecko   (  208): AboutServiceWorkers - Got content event {"name":"init","id":"10787a39-b44b-4b89-a746-2add77dc14cd"}
E/GeckoConsole(  208): [JavaScript Error: "Error: Encountered unsupported value type writing stack-scoped structured clone" {file: "resource://gre/modules/SystemAppProxy.jsm" line: 124}]

Panel is displayed but looks broken with empty placeholder for the SW.

Service Worker is registered for app:// protocol. Here is the app that was used to install SW [1] in _packaged app_ mode.

I've tried to run this app from b2g browser but it fails with "Content JS ERROR: Registration failed with  [Exception... "Illegal value"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: no]" while it's registered successfully on Fx Desktop Nightly - but it's out of scope :)

[1] http://fxos-performance.github.io/service-worker-empty/

Comment 1

[Oleg Zasypkin [:azasypkin]]

Hey Fernando,

Do you have any clue what is going on here?

Thanks!

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1224570.aboutsw > mozilla-b2g:master

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

The problem is that the sw object now includes a debugger property which is not clonable. The thing is that we don't need most of the info that we are exposing so far, so this patch makes us expose only the sw origin, scope and script url.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8697248 [details] [review]
[gaia] ferjm:bug1224570.aboutsw > mozilla-b2g:master

Yura, this patch simply removes the sw properties that we don't need to expose.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8697248 [details] [review]
[gaia] ferjm:bug1224570.aboutsw > mozilla-b2g:master

Thanks

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 8697249 [details] [diff] [review]
v1

Review of attachment 8697249 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/AboutServiceWorkers.jsm
@@ +34,5 @@
> +    originAttributes: aServiceWorkerInfo.principal.originAttributes
> +  };
> +
> +  ["scope",
> +   "scriptSpec"].forEach(property => {

nit: doesn't that fit on a single line? feel free to keep it that way if you think we may add more later.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7959433e79fd98b761d5fed5d5b894200f869848
Bug 1224570 - [Service Workers Panel] Service Workers panel fails to show registered service workers after restart. r=fabrice

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7959433e79fd