Status

()

P3
normal
3 years ago
3 days ago

People

(Reporter: jruderman, Unassigned)

Tracking

(Blocks: 1 bug, {memory-leak, testcase})

Trunk
memory-leak, testcase
Points:
---

Firefox Tracking Flags

(firefox45 affected)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8687193 [details]
testcase (requires extension)

Leaks MediaMemoryTracker and nsTArray_base, as reported by trace-refcnt.

The testcase calls fuzzPriv.getMemoryReports, which does pretty much the same calls as clicking "Measure" in about:memory, but lets the testcase control the timing. Run with https://github.com/MozillaSecurity/funfuzz/tree/master/dom/extension installed in a temporary profile. (Or modify the testcase so the timing doesn't need to be so precise?)
Component: Audio/Video → Audio/Video: Playback
You you interested in this one, Gerald?
Flags: needinfo?(gsquelart)
Priority: -- → P2
Whiteboard: [MemShrink]
It looks like we expect the MediaMemoryTracker to be cleaned up when we remove the last MediaDecoder [1]. So presumably that's not happening.

Jesse, are these the STR? Are you using a special build / env flags?
1 - Load testcase (I'm assuming this could probably just be a xpcshell test)
2 - Quit

[1] https://dxr.mozilla.org/mozilla-central/rev/a2f83cbe53ac4009afa4cb2b0b8f549289b23eeb/dom/media/MediaDecoder.cpp#103-111
Flags: needinfo?(jruderman)
(Just removing my NI, will wait for answers to Eric's questions)
Flags: needinfo?(gsquelart)
(Reporter)

Comment 4

3 years ago
1. Make a fresh profile with e10s disabled.
2. Install https://github.com/MozillaSecurity/funfuzz/tree/master/dom/extension/

   EITHER:
     A. Set xpinstall.signatures.required to false
     B. wget https://www.squarefree.com/extensions/domFuzzLite3.xpi
     C. Drag xpi to Firefox

   OR:
     A. Clone https://github.com/MozillaSecurity/funfuzz/
     B. Set a bunch of prefs
     C. Make a text file link

3. XPCOM_MEM_LEAK_LOG=2 firefox -profile <dir> q.html
4. Quit
Flags: needinfo?(jruderman)
(In reply to Gerald Squelart [:gerald] from comment #3)
> (Just removing my NI, will wait for answers to Eric's questions)

Gerald, we have STR now (and I confirmed they worked).
Flags: needinfo?(gsquelart)
Whiteboard: [MemShrink] → [MemShrink:P2]
Still in my to-do list, keeping NI as reminder.
Mass change P2 -> P3
Priority: P2 → P3

No response to NI for 3 years, clearing NI.

Flags: needinfo?(gsquelart)
You need to log in before you can comment on or make changes to this bug.