1224573 - Leak MediaMemoryTracker

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase (requires extension)

Leaks MediaMemoryTracker and nsTArray_base, as reported by trace-refcnt.

The testcase calls fuzzPriv.getMemoryReports, which does pretty much the same calls as clicking "Measure" in about:memory, but lets the testcase control the timing. Run with https://github.com/MozillaSecurity/funfuzz/tree/master/dom/extension installed in a temporary profile. (Or modify the testcase so the timing doesn't need to be so precise?)

Comment 1

[Ralph Giles (:rillian)]

You you interested in this one, Gerald?

Comment 2

[Eric Rahm [:erahm]]

It looks like we expect the MediaMemoryTracker to be cleaned up when we remove the last MediaDecoder [1]. So presumably that's not happening.

Jesse, are these the STR? Are you using a special build / env flags?
1 - Load testcase (I'm assuming this could probably just be a xpcshell test)
2 - Quit

[1] https://dxr.mozilla.org/mozilla-central/rev/a2f83cbe53ac4009afa4cb2b0b8f549289b23eeb/dom/media/MediaDecoder.cpp#103-111

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

(Just removing my NI, will wait for answers to Eric's questions)

Comment 4

[Jesse Ruderman]

1. Make a fresh profile with e10s disabled.
2. Install https://github.com/MozillaSecurity/funfuzz/tree/master/dom/extension/

   EITHER:
     A. Set xpinstall.signatures.required to false
     B. wget https://www.squarefree.com/extensions/domFuzzLite3.xpi
     C. Drag xpi to Firefox

   OR:
     A. Clone https://github.com/MozillaSecurity/funfuzz/
     B. Set a bunch of prefs
     C. Make a text file link

3. XPCOM_MEM_LEAK_LOG=2 firefox -profile <dir> q.html
4. Quit

Comment 5

[Eric Rahm [:erahm]]

(In reply to Gerald Squelart [:gerald] from comment #3)
> (Just removing my NI, will wait for answers to Eric's questions)

Gerald, we have STR now (and I confirmed they worked).

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Still in my to-do list, keeping NI as reminder.

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3

Comment 8

[Michael Froman [:mjf]]

No response to NI for 3 years, clearing NI.