Closed
Bug 1224629
Opened 9 years ago
Closed 8 years ago
Create an end-to-end test that verifies you can save a note in the Notes app
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: mbryant)
Details
Attachments
(3 files)
Steps for this test 1. Open the app 2. Create a new note with a given text 3. Go back to the main view 4. Verify the note is created with the correct information I don't think we have a test in Moztrap. Could you create one, Michael?
Comment 1•9 years ago
|
||
Shouldn't this be done in MarionetteJS?
Reporter | ||
Comment 2•9 years ago
|
||
This could be done with MarionetteJS. However I don't think we're ready to implement this test with, for the following reasons: 1. We don't have MarionetteJS running on device, on a Continuous Integration system. So any end-to-end test we'd write wouldn't be executed. 2. We could implement a Gij test for this, but Notes has no directory layout[1] like any regular app. So, we can't easily create this type of test. What do you think? [1] https://github.com/mozilla-b2g/gaia/tree/master/hosted_apps/notes
Flags: needinfo?(martijn.martijn)
Comment 3•9 years ago
|
||
I don't understand why the Notes app needs to be running on device, afaict, it should be able to run on Mulet or whatever just fine. But I guess it's an external app?
Flags: needinfo?(martijn.martijn)
Comment 4•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8708590 -
Flags: review?(jlorenzo)
Assignee | ||
Updated•8 years ago
|
Attachment #8708590 -
Flags: review?(martijn.martijn)
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8708590 [details] [review] [gaia] ubermarklar:1224629 > mozilla-b2g:master This first test is great! You got the way page objects work correctly. There are a few minor changes to make before merging the code, but it's definitely on the right track ;)
Attachment #8708590 -
Flags: review?(jlorenzo)
Comment 6•8 years ago
|
||
Comment on attachment 8708590 [details] [review] [gaia] ubermarklar:1224629 > mozilla-b2g:master Like jlorenzo's comments with some additions from me.
Attachment #8708590 -
Flags: review?(martijn.martijn)
Comment 7•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8710513 -
Flags: review?(jlorenzo)
Reporter | ||
Comment 8•8 years ago
|
||
Comment on attachment 8710513 [details] [review] [gaia] ubermarklar:1224629a > mozilla-b2g:master The test itself looks good to me. Before merging, please add the __init__.py file under tests/python/gaia-ui-tests/gaiatest/apps/notes/app.py. If this file is not present, the test will fail with this error: > ImportError: No module named notes.app
Attachment #8710513 -
Flags: review?(martijn.martijn)
Attachment #8710513 -
Flags: review?(jlorenzo)
Attachment #8710513 -
Flags: review+
Comment 9•8 years ago
|
||
Comment on attachment 8710513 [details] [review] [gaia] ubermarklar:1224629a > mozilla-b2g:master There are some things that can be improved, but in all, it looks good, apart from the issue that Johan already mentioned.
Attachment #8710513 -
Flags: review?(martijn.martijn) → review+
Reporter | ||
Comment 10•8 years ago
|
||
Like bug 1242634, this test has never landed. Do you need any help in merging the patch, Michael?
Flags: needinfo?(mbryant)
Comment 11•8 years ago
|
||
Assignee | ||
Comment 12•8 years ago
|
||
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #10) > Like bug 1242634, this test has never landed. Do you need any help in > merging the patch, Michael? Ok, I think this current PR should be the last one needed for this bug. All changes have been incorporated and extraneous text edited out.
Flags: needinfo?(mbryant)
Assignee | ||
Updated•8 years ago
|
Attachment #8723094 -
Flags: review?(jlorenzo)
Reporter | ||
Comment 13•8 years ago
|
||
Comment on attachment 8723094 [details] [review] [gaia] ubermarklar:1224629 > mozilla-b2g:master Looks good to me.
Attachment #8723094 -
Flags: review?(jlorenzo) → review+
Reporter | ||
Comment 14•8 years ago
|
||
Landed in master at: https://github.com/mozilla-b2g/gaia/commit/f45c8328f01b7eb75a131b4d1ed9ebdd50dc4aa2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•