1224783 - TraceLogger: Considering enable TraceLogger_VM when 'Default' is set

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Wei Wu [:wuwei UTC+8]]

Attachment: enable_vm_when_default_set.patch

Currently TraceLogger_VM is not enabled in 'TLLOG=Default'. The patch enables it.

On the other hand, if TraceLogger_VM is supposed not to enable implicitly, some docs might be needed. (there is another bug for the doc.)

Comment 1

[Hannes Verschore [:h4writer]]

Comment on attachment 8687503 [details] [diff] [review]
enable_vm_when_default_set.patch

Review of attachment 8687503 [details] [diff] [review]:
-----------------------------------------------------------------

I indeed disabled VM by default. It is quite easy to enable by:
TLLOG=Default,VM

Fyi,
TLLOG=help 
will give you documentation ;)

Comment 2

[Wei Wu [:wuwei UTC+8]]

(In reply to Hannes Verschore [:h4writer] from comment #1)
> Comment on attachment 8687503 [details] [diff] [review]
> enable_vm_when_default_set.patch
> 
> Review of attachment 8687503 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I indeed disabled VM by default. It is quite easy to enable by:
> TLLOG=Default,VM

Got it :)

> Fyi,
> TLLOG=help 
> will give you documentation ;)

TLLOG=help lists what can be enabled, but doesn't list what are included in 'Default'.
btw I filed bug 1224809 for it :P