1224809 - TraceLogger: Document what are enabled in 'TLLOG=Default' and 'TLLOG=IonCompiler'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Wei Wu [:wuwei UTC+8]]

According to bug 1221460 and bug 1224783, it might be good to list enabled channels/events when 'TLLOG=Default' and 'TLLOG=IonCompiler' are given. Currently one could not see these information unless digging into TraceLogger's source code.

The basic idea is adding a comment in the TLLOG=help usage, like

> usage: TLLOG=option,option,option,... where options can be:
> 
> Collections:
>  Default        Output all default, which enables
>    [LIST OF ENABLED EVENTS]
>    [LIST OF ENABLED EVENTS]
>    [LIST OF ENABLED EVENTS]
>  IonCompiler    Output all information about compilation, which enables
>    [LIST OF ENABLED EVENTS]
>    [LIST OF ENABLED EVENTS]
>    [LIST OF ENABLED EVENTS]
> 
> Specific log items:
>    All the events listed above
> This items you should (have to) enable them explicitly:
>    InlinedScripts (Blocks IonMonkey's inlinling currently)
>    IonCompilationPaused (forgot to enable?)

I would like to submit a patch if it is worth to improve it :)

Comment 1

[Hannes Verschore [:h4writer]]

Feel free to add that ;) (Except those 3 last lines. One should be able to deduce that knowing what is enabled in Default/IonCompiler).
I'm not sure what the best representation would be. But if possible can you have one line long line, instead of a newline for every event that is included in a collection. I think it else might become too long...

Comment 2

[Wei Wu [:wuwei UTC+8]]

Attachment: patch

Show what are included in the collections.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0e2e7a10265

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a0e2e7a10265