Closed
Bug 1224809
Opened 9 years ago
Closed 9 years ago
TraceLogger: Document what are enabled in 'TLLOG=Default' and 'TLLOG=IonCompiler'
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: wuwei, Assigned: wuwei)
References
Details
Attachments
(1 file)
2.19 KB,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
According to bug 1221460 and bug 1224783, it might be good to list enabled channels/events when 'TLLOG=Default' and 'TLLOG=IonCompiler' are given. Currently one could not see these information unless digging into TraceLogger's source code. The basic idea is adding a comment in the TLLOG=help usage, like > usage: TLLOG=option,option,option,... where options can be: > > Collections: > Default Output all default, which enables > [LIST OF ENABLED EVENTS] > [LIST OF ENABLED EVENTS] > [LIST OF ENABLED EVENTS] > IonCompiler Output all information about compilation, which enables > [LIST OF ENABLED EVENTS] > [LIST OF ENABLED EVENTS] > [LIST OF ENABLED EVENTS] > > Specific log items: > All the events listed above > This items you should (have to) enable them explicitly: > InlinedScripts (Blocks IonMonkey's inlinling currently) > IonCompilationPaused (forgot to enable?) I would like to submit a patch if it is worth to improve it :)
Flags: needinfo?(hv1989)
Comment 1•9 years ago
|
||
Feel free to add that ;) (Except those 3 last lines. One should be able to deduce that knowing what is enabled in Default/IonCompiler). I'm not sure what the best representation would be. But if possible can you have one line long line, instead of a newline for every event that is included in a collection. I think it else might become too long...
Flags: needinfo?(hv1989)
Assignee | ||
Comment 2•9 years ago
|
||
Show what are included in the collections.
Attachment #8689363 -
Flags: review?(hv1989)
Updated•9 years ago
|
Attachment #8689363 -
Flags: review?(hv1989) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a0e2e7a10265
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•