TraceLogger: Document what are enabled in 'TLLOG=Default' and 'TLLOG=IonCompiler'

RESOLVED FIXED in Firefox 45

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: wuwei, Assigned: wuwei)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
According to bug 1221460 and bug 1224783, it might be good to list enabled channels/events when 'TLLOG=Default' and 'TLLOG=IonCompiler' are given. Currently one could not see these information unless digging into TraceLogger's source code.

The basic idea is adding a comment in the TLLOG=help usage, like

> usage: TLLOG=option,option,option,... where options can be:
> 
> Collections:
>  Default        Output all default, which enables
>    [LIST OF ENABLED EVENTS]
>    [LIST OF ENABLED EVENTS]
>    [LIST OF ENABLED EVENTS]
>  IonCompiler    Output all information about compilation, which enables
>    [LIST OF ENABLED EVENTS]
>    [LIST OF ENABLED EVENTS]
>    [LIST OF ENABLED EVENTS]
> 
> Specific log items:
>    All the events listed above
> This items you should (have to) enable them explicitly:
>    InlinedScripts (Blocks IonMonkey's inlinling currently)
>    IonCompilationPaused (forgot to enable?)

I would like to submit a patch if it is worth to improve it :)
Flags: needinfo?(hv1989)
(Assignee)

Updated

3 years ago
Depends on: 1224456
Feel free to add that ;) (Except those 3 last lines. One should be able to deduce that knowing what is enabled in Default/IonCompiler).
I'm not sure what the best representation would be. But if possible can you have one line long line, instead of a newline for every event that is included in a collection. I think it else might become too long...
Flags: needinfo?(hv1989)
(Assignee)

Comment 2

3 years ago
Created attachment 8689363 [details] [diff] [review]
patch

Show what are included in the collections.
Attachment #8689363 - Flags: review?(hv1989)
Attachment #8689363 - Flags: review?(hv1989) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a0e2e7a10265
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.