1224849 - Crash in WebKit: WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker()

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Heavy volume crash on Firefox 1.1


Last Exception Backtrace:
0   CoreFoundation                	0x185434f48 __exceptionPreprocess + 124 (NSException.m:162)
1   libobjc.A.dylib               	0x199fe7f80 objc_exception_throw + 56 (objc-exception.mm:531)
2   CoreFoundation                	0x185434e90 +[NSException raise:format:] + 120 (NSException.m:140)
3   WebKit                        	0x18b6c1ec0 WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker() + 144 (CompletionHandlerCallChecker.mm:54)
4   WebKit                        	0x18b70b928 WTF::ThreadSafeRefCounted<WebKit::CompletionHandlerCallChecker>::deref() + 40 (ThreadSafeRefCounted.h:112)
5   WebKit                        	0x18b77e6f8 __destroy_helper_block_ + 36 (PassRefPtr.h:42)
6   libsystem_blocks.dylib        	0x19a8618e8 _Block_release + 156 (runtime.c:312)
7   Client                        	0x10026ad78 0x1000e4000 + 1600888
8   Client                        	0x10026ade8 0x1000e4000 + 1601000
9   libsystem_blocks.dylib        	0x19a8618e8 _Block_release + 156 (runtime.c:312)
10  UIKit                         	0x18ae2d910 -[UIAlertController _clearActionHandlers] + 204 (UIAlertController.m:1020)
11  UIKit                         	0x18ae2bc04 -[UIAlertController dealloc] + 368 (UIAlertController.m:519)

Symbolicate me!

Comment 1

[Stephan Leroux [:sleroux]]

Hard to tell if this particular log was for 32 or 64 bit but the 64 bit symbols look more promising:

arm64:
@objc BrowserViewController.webView(WKWebView, didReceiveAuthenticationChallenge : NSURLAuthenticationChallenge, completionHandler : (NSURLSessionAuthChallengeDisposition, NSURLCredential?) -> ()) -> () (in Client) (BrowserViewController.swift:1561)
@objc BrowserViewController.webView(WKWebView, didReceiveAuthenticationChallenge : NSURLAuthenticationChallenge, completionHandler : (NSURLSessionAuthChallengeDisposition, NSURLCredential?) -> ()) -> () (in Client) (BrowserViewController.swift:1561)

armv7
specialized _NativeSetStorage._find<A where ...>(A, Int) -> (pos : _NativeSetIndex<A>, found : Bool) (in Client) (TabManager.swift:0)
specialized _NativeSetStorage._find<A where ...>(A, Int) -> (pos : _NativeSetIndex<A>, found : Bool) (in Client) (TabManager.swift:0)

Comment 2

[Stephan Leroux [:sleroux]]

Not sure if it's related but the crash looks like it starts from a UIAlertController. This might be happening in cases where we open a new tab from a popup or context menu?

Comment 3

[Richard Newman [:rnewman]]

My guess would be an HTTP Basic Auth prompt where the callback doesn't correctly retain something.

Comment 4

[Aaron Train [:aaronmt]]

Turns out this is simple to reproduce 

We fail to show basic HTTP auth dialogs in private tabs which cause this crash.

Comment 5

[Aaron Train [:aaronmt]]

Attachment: symbolicated-crash.crash

Comment 6

[Brian Nicholson (:bnicholson)]

Looks like a regression from bug 1204539 since we disable the LoginsHelper for private tabs, but assume the helper is there to show these auth dialogs.

Comment 7

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1302

Comment 8

[Emily Toop (:fluffyemily)]

Comment on attachment 8691606 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1302

Separating logins detection/fill & authentication handling is definitely a good idea.

Works great. Any chance of a test?

Comment 9

[Brian Nicholson (:bnicholson)]

master: https://github.com/mozilla/firefox-ios/commit/75ec934e58ffe9d8ecd44bf0a2d851ea137c986a
v1.x: https://github.com/mozilla/firefox-ios/commit/5b16834a4cb6d94035af34335e64f4dec498560e