1224855 - Crash in UIKit: -[UIPasteboard(UIPasteboardDataExtensions) setImage:]

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Last Exception Backtrace:
0   CoreFoundation                	0x1862f4f48 __exceptionPreprocess + 124 (NSException.m:162)
1   libobjc.A.dylib               	0x19aea7f80 objc_exception_throw + 56 (objc-exception.mm:531)
2   CoreFoundation                	0x1862f4e90 +[NSException raise:format:] + 120 (NSException.m:140)
3   UIKit                         	0x18bdbde5c -[UIPasteboard(UIPasteboardDataExtensions) setImage:] + 168 (UIPasteboard.m:620)
4   Client                        	0x10020d164 specialized BrowserViewController.(contextMenuHelper(BrowserViewController) -> (ContextMenuHelper, didLongPressElements : ContextMenuHelper.Elements, gestureRecognizer : UILongPressGestureRecognizer) -> ()).(closure #5).(closure #2) + 428 (BrowserViewController.swift:2176)
5   Alamofire                     	0x1018bcb68 Request.(response(Request) -> (queue : OS_dispatch_queue?, completionHandler : (NSURLRequest?, NSHTTPURLResponse?, NSData?, NSError?) -> ()) -> Self).(closure #1).(closure #1) + 236 (ResponseSerialization.swift:85)
6   libdispatch.dylib             	0x19b6c56e8 _dispatch_call_block_and_release + 24 (init.c:760)
7   libdispatch.dylib             	0x19b6c56a8 _dispatch_client_callout + 16 (object.m:506)
8   libdispatch.dylib             	0x19b6cadb0 _dispatch_main_queue_callback_4CF + 1844 (inline_internal.h:1063)
9   CoreFoundation                	0x1862ac1f8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12 (CFRunLoop.c:1613)
10  CoreFoundation                	0x1862aa060 __CFRunLoopRun + 1628 (CFRunLoop.c:2718)
11  CoreFoundation                	0x1861d8ca0 CFRunLoopRunSpecific + 384 (CFRunLoop.c:2814)
12  GraphicsServices              	0x191414088 GSEventRunModal + 180 (GSEvent.c:2245)
13  UIKit                         	0x18b8f0ffc UIApplicationMain + 204 (UIApplication.m:3665)
14  Client                        	0x1000a5e9c main + 332 (main.swift:22)
15  libdyld.dylib                 	0x19b6f68b8 start + 4 (start_glue.s:80)

Comment 1

[Richard Newman [:rnewman]]

Brian, any clues?

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1285

Looking at our Copy Image code, I see a few different issues:

1. In the Alamofire response, we do application.endBackgroundTask() only if the pasteboard string equals the copied string. We do this check to prevent replacing the pasteboard contents in case it's changed after any long-running image fetching, but ending the background task should be done unconditionally.

2. UIImage(data: NSData) can return nil if the image creation fails for whatever reason, and we don't guard against this. I tested explicitly assigning pasteBoard.image = nil, and that caused the same crash reported in the bug, so I'm guessing that's the issue. Not sure why iOS allows setting a nil image if it's not supported!

3. Setting the image replaces the image URL text in the pasteboard. The iOS pasteboard supports multiple representations simultaneously for an item on the pasteboard, so in this case, the pasteboard should hold both the image and its URL (e.g., for when pasting into text fields). This is consistent with Safari.

Comment 3

[Emily Toop (:fluffyemily)]

Comment on attachment 8689788 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1285

See comments about incorrect file type being displayed in iMessage/Messages when copying image of type JPEG.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8689788 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1285

Updated with commentary.

Comment 5

[Brian Nicholson (:bnicholson)]

STR crash, for the sake of completeness:
1) Go to http://people.mozilla.org/~bnicholson/test/image.html.
2) Long press and choose Copy Image.

Comment 6

[Emily Toop (:fluffyemily)]

Comment on attachment 8689788 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1285

Yup, this last patch fixes it and renders the right image with the correct URL fallback.

Comment 7

[Brian Nicholson (:bnicholson)]

Master: 60a3b28
v1.x: a0be117

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Reproduced the issue on version 1.2 build 1206 using Iphone 6 (IOS 9.1). Verified as fixed on version 1.3 build 1308.