1224937 - Scrollbar in "Show your bookmarks"

Status: RESOLVED INCOMPLETE

(Firefox :: Toolbars and Customization, defect)

Description

[Michael Monreal [:micmon]]

Attachment: Screenshot from 2015-11-15 20-07-20.jpg

The "Show your bookmarks" menu shows scrollbars even when it does not fill the whole screen (see screenshot). The scrolling is minimal, so the menu should just be a few pixels wider and taller.

I think this only happens on Linux, as I have never seen this on Windows before.

One guess: maybe Firefox assumes wider scrollbars than what the GNOME default theme (Adwaita) now uses?

Comment 1

[:Gijs (he/him)]

Can you reproduce this if you restart in safe mode? ( Help > Restart with add-ons disabled )

Comment 2

[Michael Monreal [:micmon]]

Yes. I only use two addons (ublock and noscript) and I can reproduce with both disabled.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

which distribution and window manager?
Off-hand sounds like another window manager popup positioning/sizing bug :(

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

ah sorry, I see in comment 0 it's gnome with adwaita theme. your theory is likely. there may also be a relation with recent gtk3 work.

Comment 5

[:Gijs (he/him)]

(In reply to Marco Bonardo [::mak] from comment #4)
> ah sorry, I see in comment 0 it's gnome with adwaita theme. your theory is
> likely. there may also be a relation with recent gtk3 work.

This was reported on 42, where gtk3 was turned off pretty late. It is of course possible that there's a regression related to CSS adjustments made for gtk3 that were then "broken" by switching back to gtk2...

I'm building to see if I can reproduce. I wonder if this needs bookmarks of a particular (title/label) length / arrangement, and/or theme font size, though... my experience with linux theme issues is that there are even more variables at play than on Windows...

Comment 6

[:Gijs (he/him)]

FWIW, I can't reproduce this with the default adwaita stuff in Ubuntu 14.04 on either my usual or a clean profile, on neither Ubuntu's copy of 42 nor on self-built Nightly. :-(

Comment 7

[Michael Monreal [:micmon]]

No longer relevant with Photon theme.

Comment 8

[:Gijs (he/him)]

(In reply to Michael Monreal [:micmon] from comment #7)
> No longer relevant with Photon theme.

We still ship this button, it's just not visible by default. Is the issue really gone?

Comment 9

[Michael Monreal [:micmon]]

Well I am unable to reproduce the Problem on Firefox 58 nightly and thought it was fixed during the Photon theming rework. If anyone can still reproduce this, feel free to reopen.