Closed
Bug 1224991
Opened 9 years ago
Closed 9 years ago
Log format string mismatch the number of parameters.
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: JamesCheng, Assigned: JamesCheng)
Details
Attachments
(1 file, 1 obsolete file)
1.06 KB,
patch
|
JamesCheng
:
review+
|
Details | Diff | Splinter Review |
Log format string mismatch the number of parameters in HTMLMediaElement.cpp https://dxr.mozilla.org/mozilla-central/rev/7cd2d806bd069c0260ff73f023ac85f892b863bf/dom/html/HTMLMediaElement.cpp#983
Assignee | ||
Comment 1•9 years ago
|
||
Hi Chris, Could you please review this simple patch? Thank you.
Attachment #8687766 -
Flags: review?(cpearce)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jacheng
Comment 2•9 years ago
|
||
Comment on attachment 8687766 [details] [diff] [review] Log-format-string-mismatch-the-number-of.patch Review of attachment 8687766 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/html/HTMLMediaElement.cpp @@ +975,3 @@ > } > > void HTMLMediaElement::NotifyMediaTrackEnabled(MediaTrack* aTrack) Perhaps we should instead copy the logic in HTMLMediaElement::NotifyMediaStreamTrackRemoved() to log the id of the track enabled? r+ with that change.
Attachment #8687766 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Carry r+ and log with the track id instead.
Attachment #8687766 -
Attachment is obsolete: true
Attachment #8688213 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Component: Audio/Video → Audio/Video: Playback
Comment 5•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f8c8a8f403fb
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•