Closed Bug 1225004 Opened 9 years ago Closed 9 years ago

record reason for NS_ERROR_FILE_CORRUPTED in nsLayoutStylesheetCache::LoadSheet in crash reports

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox42 --- affected
firefox43 --- fixed
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Still investigating bug 1194856.  This patch reports the reason we returned NS_ERROR_FILE_CORRUPTED while trying to load a UA style sheet.  It also reports the crc32 of files (such as omni.ja) in the crash report notes so we can check them against what they should be for the given Firefox version.  The file sizes, which we're currently reporting, have looked right so far.
Attachment #8687777 - Flags: review?(roc)
Comment on attachment 8687777 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1169514
[User impact if declined]: less chance of working out what's causing UA style sheet loading failure
[Describe test coverage new/current, TreeHerder]: none; just landed on inbound
[Risks and why]: low, this just adds some additional crash report notes
[String/UUID change made/needed]: N/A
Attachment #8687777 - Flags: approval-mozilla-beta?
Attachment #8687777 - Flags: approval-mozilla-aurora?
Hello, this is failing to build on Linux x64 ASAN builds. Can you look urgently? If I don't hear back in 5 minutes, I'll back it out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/74a949559633b776a2509e7cd6ffd5b3d81e1ff3
Backed out changeset 6d47b0590988 (bug 1225004) for ASAN build bustage on a CLOSED TREE
https://hg.mozilla.org/mozilla-central/rev/1ec80d27792a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Looks like this is an issue at least back to 41. Marking affected.
Comment on attachment 8687777 [details] [diff] [review]
patch

Improvement for crash diagnosis including startup crashes, ok to uplift to aurora and beta.
Attachment #8687777 - Flags: approval-mozilla-beta?
Attachment #8687777 - Flags: approval-mozilla-beta+
Attachment #8687777 - Flags: approval-mozilla-aurora?
Attachment #8687777 - Flags: approval-mozilla-aurora+
Hi, this failed to apply to beta:

can you take a look, thanks!

merging layout/style/nsLayoutStylesheetCache.cpp
warning: conflicts during merge.
merging layout/style/nsLayoutStylesheetCache.cpp incomplete! (edit conflicts, then use 'hg resolve --mark')
merging modules/libjar/nsJAR.cpp
merging modules/libjar/nsZipArchive.cpp
merging modules/libjar/nsZipArchive.h
merging xpcom/build/FileLocation.cpp
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)
Flags: needinfo?(cam)
You need to log in before you can comment on or make changes to this bug.