1225022 - [TV][Browser][Private browsing] The content's size is wrong

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: SSTV_Browser_Specifcation_v04

STR:
 1. Launch Browser
 2. Go to Menu
 3. Select "New private window" and press OK

Expected Result:
 - Please see the attachment, pages 20-21

Comment 1

[Evelyn Hung]

Also, the font size is too small.
Dan, can you fix here?

Comment 2

[Dan Huang[:danhuang]]

After confirmed with UX time, the title font-size should be 4.6rem, the sub-title font-size should be 2.6rem and the other font-size should be 2.4rem.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1225022_revice_private_browse_page > mozilla-b2g:master

Comment 4

[Dan Huang[:danhuang]]

Comment on attachment 8692533 [details] [review]
[gaia] danhuang1202:1225022_revice_private_browse_page > mozilla-b2g:master

Hi Yi-fan, please help review. This patch revise the style of private browsing page, and update awesomescreen.css Thanks.

Comment 5

[yifan [:yifan][:yliao]]

Please also provide screenshots for the visual team and set the ui-review flag.

Comment 6

[Dan Huang[:danhuang]]

Attachment: private_browsing_screenshot_1130.png

Hi Peko, please help me to review the screen shot of private browsing. Thanks.

Comment 7

[Peko Chen [:pekochen]]

Attachment: private_browsing_screenshot_1130_review.png

Hi Dan,
Thanks for your effort!
Please see attached image for your reference.
there are some small details need to be fine tune.
Thanks!

Comment 8

[Dan Huang[:danhuang]]

Attachment: private_browsing_screenshot_1130v2.png

Hi Peko, please help review again! This screen shot remove the outstroke and update background color. Thanks.

Comment 9

[yifan [:yifan][:yliao]]

Comment on attachment 8692533 [details] [review]
[gaia] danhuang1202:1225022_revice_private_browse_page > mozilla-b2g:master

LGTM! Thanks!

Comment 10

[Dan Huang[:danhuang]]

Thanks for the code and ui review.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/55b605af9dd4500a0a449b15b0016426c27c79a8

Comment 11

[Dan Huang[:danhuang]]

Comment on attachment 8692533 [details] [review]
[gaia] danhuang1202:1225022_revice_private_browse_page > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1187806
[User impact] if declined: Not align to the UX spec
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=01950e6c8e31b7f847e8ec1dc8ce22a859cb7fe3
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: Yes

Comment 12

[Josh Cheng [:josh]]

Comment on attachment 8692533 [details] [review]
[gaia] danhuang1202:1225022_revice_private_browse_page > mozilla-b2g:master

Approve for TV 2.5

Comment 13

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/e125c8db4524fc3c02f492d25a7394afc79081b4