Open Bug 1225025 Opened 4 years ago Updated 3 years ago

Type inference for TypedArray mapping SharedArrayBuffer

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

defect

Tracking

()

People

(Reporter: lth, Unassigned)

References

(Blocks 1 open bug)

Details

In plain JS code, the jit now (bug 1176214) emits a guard before atomic operations to check that the TypedArray argument maps shared memory.  It will be nice to optimize that guard away when we can.

When a TypedArray is created that maps a SAB the TA's ObjectGroup will reflect that fact (a new flag).  Type inference can then pick up that flag and MCallOptimize can use the information to omit the guard when the TA argument is known always to map shared memory.  The higher-level parts of that logic are already in bug 1176214, but the ObjectGroup/TI parts are not.

Another reason for TI here is for us to be able to tell the difference between when a TA operation is definitely not mapping shared memory, and when it might be.  There are some optimizations that may be legal only in the former case (re-loading a value from memory for example), this is TBD and depends on the final memory model spec.
See Also: → 1225452
Priority: -- → P5
Priority: P5 → P3
Blocks: 1317626
No longer blocks: shared-array-buffer
Assignee: lhansen → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.