1225054 - In room list, if a room name is too long and requires "...", the "..." renders over the menu items of the pen menu

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Comment 1

[Romain Testard [:RT]]

Attachment: Capture d’écran 2015-11-16 à 11.44.50.png

Snapshot of the issue

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: In room list, if a room name is too long and requires "...", the "..." renders over the menu items of the pen menu.

Mike, can you review the patch? it should be quick. I've just added a css rule =)

Thanks!

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: ellipsis.png

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Manuel Casas Barrado [:mancas] from comment #2)
> Mike, can you review the patch? it should be quick. I've just added a css
> rule =)
> 
> Thanks!

Sure, but what's the cause of the ellipsis showing on top of the dropdown?

Comment 5

[Manuel Casas Barrado [:mancas]]

If we don't set a z-index, the default value for the rule will be "auto", and according to the w3c:

The stack level of the generated box in the current stacking context is 0. The box does not establish a new stacking context unless it is the root element. [1]

So the ellipsis is in the same stack level.

[1] http://www.w3.org/TR/CSS2/visuren.html#z-index

Comment 6

[Mike de Boer [:mikedeboer]]

I understand how z-index works :-) No, what I meant was that I don't understand that the absolutely positioned element (dropdown) would render on top of the text, except for the ellipsis which is there because of `text-overflow: ellipsis`. This must be a platform issue.

Comment 7

[Mike de Boer [:mikedeboer]]

Comment on attachment 8687932 [details] [diff] [review]
In room list, if a room name is too long and requires "...", the "..." renders over the menu items of the pen menu.

Review of attachment 8687932 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like this work around is necessary! Thanks, Manu.

Comment 8

[Manuel Casas Barrado [:mancas]]

Ah! Maybe you're right and this is a platform issue, because the ellipsis is generated and rendered by the browser =)

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/055104774f5d

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/055104774f5d