1225085 - [TV][2.5] Press option will ask to add webapp to Apps when user is navigating in preview content

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

After user opened webapp content from marketplace, a hint on the screen informs the user that they can press “option” to add content to Apps.

When user presses "option", an action menu is shown with the option to add the content to Apps.

User is able to presses “ok” to add the content to Apps or press "back" to cancel this action. After that, a banner is displayed informing the user that the content has been added to Apps.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:previewContextMenu > mozilla-b2g:master

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Attachment: New marketplace website for testing and demo

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8696749 [details] [review]
[gaia] rickychien:previewContextMenu > mozilla-b2g:master

Hi Luke,

Feature for pressing option (context menu) inside preview window to prompt add / delete a particular app is complete.

An additional patch including for new hosted marketplace website for demo or testing. Please apply both of patches and take a look of it. thanks!

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8696749 [details] [review]
[gaia] rickychien:previewContextMenu > mozilla-b2g:master

Hi Ricky,

Please take a look at my comments on GitHub. Thanks.

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8696749 [details] [review]
[gaia] rickychien:previewContextMenu > mozilla-b2g:master

Looks good now. Thanks.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Landed in master

https://github.com/mozilla-b2g/gaia/commit/4ebf0d3e6f156606e1e0939e998eedaa8767d894

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8696749 [details] [review]
[gaia] rickychien:previewContextMenu > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1211400
[User impact] if declined: impact system app but all test cases are passed
[Testing completed]: verified locally as well as CI tests
[Risk to taking this patch] (and alternatives if risky):
[String changes made]: none

Comment 8

[Josh Cheng [:josh]]

Comment on attachment 8696749 [details] [review]
[gaia] rickychien:previewContextMenu > mozilla-b2g:master

Approve for TV 2.5

Comment 9

[Pi Wei Cheng [:piwei] (inactive)]

Excluding this in our queries since we're not working on the TV project.

Comment 10

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/78b3777726406554321d8bdaa604f4225b887ee0 for 2.5

Comment 11

[Rid Pan]

Verify this issue on the latest build.
1. When launching a webapp content, the hint banner "Press OPTION to Add to Apps" shows up on the right-bottom of the screen.
2. After pressing the OPTION key, the "Add to Apps" icon will pop up.
3. If pressing the OK key, the hint banner "[webapp' name] was added to Apps" will pop up on the bottom of the screen; if pressing the Back key, it will cancel the action and back to the previous page.

[Build Info]
Environment: Simulator 2.5.20160215231509
gaia:
https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/227c6d4926c154167a2214e123253f2c937e4106
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3

[Build Info]
Environment: Simulator 2.6.20160222133739
gaia:
https://github.com/mozilla-b2g/gaia/commit/435a9320454ccc3ffdebff4d5d680f1254a15e26
gecko:
https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec