1225088 - [TV][2.5] Showing a content splash screen when content loading is slow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P3)

Description

[Ricky Chien [:rickychien] (inactive)]

If the content is slow to load or install a splash screen is shown with the icon on of the content centered on a white background and below the icon a progress bar is displayed.

When the content has finished loading the splash screen is dismissed and the content is shown.

The user is able to press “back” on the remote to cancel loading the content and return to marketplace.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Hi Josh,

This feature should be descoped since marketplace is going to target on websites and hosted apps currently without packaged apps. Content loading should not be too slow when opening a website or hosted app. As a result, we prefer to move it as 2.6?

Comment 2

[Josh Cheng [:josh]]

(In reply to Ricky Chien [:rickychien] from comment #1)
> Hi Josh,
> 
> This feature should be descoped since marketplace is going to target on
> websites and hosted apps currently without packaged apps. Content loading
> should not be too slow when opening a website or hosted app. As a result, we
> prefer to move it as 2.6?

Agree, let's move this to 2.6. Thanks!

Comment 3

[Josh Cheng [:josh]]

Hi Ricky,
Could you provide ETA date if you can start the work now?
Thanks

Comment 4

[Ricky Chien [:rickychien] (inactive)]

After offline discussion, this bug will not make the progress bar running in downloading / installing phase, instead it will start to detect the loading progress in preview content loading.

I'll start the work right now and hope we can finish it this weekend.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Finally, we decided to show up a spinning icon instead of progress bar because we are unable to detect assets loading progress inside an iframe. I'm going to investigate the implementation in preview_window.js and start the work once new visual spec comes out.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master

Comment 7

[Joseph Yeh [:joseph]]

Comment on attachment 8724000 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master

Hi Luke, this patch will add a spinner and show it when launching the preview window.
Please take a look at it, thanks!

Comment 8

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8724000 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master

The "smart-spinner" is not a web component so you don't need to put it in the "bower_components" folder. Otherwise, you should add a repository to "fxos-components" [1] for that.

[1] https://github.com/fxos-components

Comment 9

[Joseph Yeh [:joseph]]

Comment on attachment 8724000 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master

Hi Luke, web component has removed. Thanks.

Comment 10

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8724000 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master

It's almost done! Please alter it a bit per our discussion. Thanks.

Comment 11

[Joseph Yeh [:joseph]]

Comment on attachment 8724000 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master

Hi Luke, splash screen is now a sub component of AppWindow. Thanks!

Comment 12

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8724000 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master

Looks great! Thanks.

Comment 13

[Joseph Yeh [:joseph]]

Landed in gaia master.

https://github.com/mozilla-b2g/gaia/commit/ae8fe4552de265860970162f1d199ec6326fc51d

Comment 14

[Joseph Yeh [:joseph]]

Comment on attachment 8724000 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1225088
[User impact] if declined: No splash screen when content loading is slow
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No

Comment 15

[Josh Cheng [:josh]]

Comment on attachment 8724000 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1225088 > mozilla-b2g:master

Approve for TV 2.5

Comment 16

[cindylee]

Verified this issue on v2.6 latest build and the spinning icon shows when launching a slow content in preview mode.

[Build Info]
2.6 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/ae8fe4552de265860970162f1d199ec6326fc51d
gecko:
https://hg.mozilla.org/mozilla-central/rev/5a2e0878d6c258b36b0ee8712a2afcde6ad94c78

Comment 17

[Mike Lien[:mlien]]

Hi Helen, do we have new version of visual spec here?

Comment 18

[GitHub Autolander Bot]

Attachment: [gaia] jostw:v2.5 > mozilla-b2g:v2.5

Comment 19

[Joseph Yeh [:joseph]]

Uplift to gaia v2.5

https://github.com/mozilla-b2g/gaia/commit/f2ee71a3cffa6a536b8dc558e6c013d7595f9c2e

Comment 20

[cindylee]

Verified this issue on following build and the spinning icon shows properly when launching a slow content in preview mode.
[Build Info]
gaia:
https://github.com/mozilla-b2g/gaia/commit/f2ee71a3cffa6a536b8dc558e6c013d7595f9c2e
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/55524f2fac552f8e3074bcf220a2d138f4ea3201
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3

Comment 21

[Mike Lien[:mlien]]

Hi Tori, do we have new version of UX spec here?

Comment 22

[Mike Lien[:mlien]]

Test case creation: https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=100&sortfield=created_on&sortdirection=desc&filter-id=17935&filter-id=18006

Comment 23

[Helen Huang [:HHuang]]

ni Peko. For some reason, Peko is the visual owner for Marketplace now and she will help to update the visual spec.

Comment 24

[Tori Chen [:tori]]

Clear this ni. It will be updated in visual spec.

Comment 25

[Peko Chen [:pekochen]]

Hi 
Please check the path as below for new visual spec
https://drive.google.com/open?id=0B4K8q1qWmtAvUTJGTFA3c2xOb0k
I changed progress bar to spinner.
Thanks

Comment 26

[Joseph Yeh [:joseph]]

Reopen this bug for adding icon under the spinner.

Comment 27

[Luke Chang [:lchang] (inactive)]

Please file another bug to follow up (unless you want to backout this one first).

Comment 28

[Joseph Yeh [:joseph]]

Please see follow up bug 1257767 for adding icon under the spinner.