1225122 - Notification for emails with no subject shows 'Undefined'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

B2G 2.6 20151115150212 on Flame

If Email checks for new messages in the background and finds a new one with no subject, it will show 'Undefined' as subject.

Steps to reproduce:
1. Set up new mail account.
2. Configure account to check every 5 minutes for mail (or more often after enabling developer mode).
3. Send a mail with no subject to that account (body I used 'test 2'). Disable after programs which that account if necessary.
4. Keep screen turned on and wait for the mail to get fetched by Email.

There is a l10n string which should be used in that case: notification-no-subject

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Thanks for the bug.  Can you indicate what type of account is this?  (Specifically IMAP/POP3/ActiveSync, see https://wiki.mozilla.org/Gaia/Email/RequiredBugInfo for more details.)

This is likely a UI regression, because we had a bug like this before for ActiveSync and maybe others and I thought we locked things down at that point, at least in the back-end.

Comment 2

[James Burke [:jrburke]]

I believe this is a regression from bug 1223275, looks like I missed in review taking a slightly different path for the no subject case. Working up a fix now.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] jrburke:bug1225122-email-notification-no-subject > mozilla-b2g:master

Comment 4

[James Burke [:jrburke]]

Comment on attachment 8688216 [details] [review]
[gaia] jrburke:bug1225122-email-notification-no-subject > mozilla-b2g:master

Notes in the pull request, fairly straightforward change.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8688216 [details] [review]
[gaia] jrburke:bug1225122-email-notification-no-subject > mozilla-b2g:master

Looks good.  And restating my understanding of the problem; the pre-patch state used "titleL10n = titleL10n || 'notification-no-subject';" which did not work because titleL10n was an object of the form { raw: undefined } and by definition truthy on its own.

Comment 6

[James Burke [:jrburke]]

You are correct in your restatement of the core problem.

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/6d68dfb8823d6b5f3cbed8af803c2f107680b62a