1225123 - memory leak in pk11mode

Status: NEW

(NSS :: Libraries, defect, P3)

Description

[vinit jain]

Attachment: pk11mode_mlk.patch

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.134 Safari/537.36

Steps to reproduce:

There is a memory leak in File: nss/cmd/pk11mode/pk11mode.c +3587
I catch this issues while code review.



Actual results:

memory to var "pTemplate" has been assigned using calloc as line no. 3560

 pTemplate = (CK_ATTRIBUTE_PTR)calloc(number_of_all_known_attribute_types,
                                         sizeof(CK_ATTRIBUTE));

At line no. 3587 function is returning without freeing this memory.


Expected results:

Memory must be freed in this case. As at a very first step 
crv = pFunctionList->C_FindObjects(h, &o, 1, &nObjects);
if ( CKR_OK != crv ) {
            PKM_Error(  "C_FindObjects(%lu, , 1, ) returned 0x%08X, %-26s\n",
                        h, crv, PKM_CK_RVtoStr(crv));
            return crv;
        }

if this call falls will leak the allocated memory. I am attaching the fixed patch for this issue.

Comment 1

[Wan-Teh Chang]

Comment on attachment 8687935 [details] [diff] [review]
pk11mode_mlk.patch

Review of attachment 8687935 [details] [diff] [review]:
-----------------------------------------------------------------

::: nss_org/cmd/pk11mode/pk11mode.c
@@ +3584,4 @@
>          if ( CKR_OK != crv ) {
>              PKM_Error(  "C_FindObjects(%lu, , 1, ) returned 0x%08X, %-26s\n", 
>                          h, crv, PKM_CK_RVtoStr(crv));
> +	    free(pTemplate);

Vinit,

Thank you for the patch. Every return statement after we have
allocated pTemplate successfully will need to free pTemplate.
So this patch needs more work.

Also, the variable pT2 has a similar leak. pT2 is freed at the
end of the while loop, but not at other return statements inside
the while loop.

When you write the full fix, please carefully check every return
statement after the variable in question is successfully allocated.

Comment 2

[christonechen]

Hello. May I work on this issue?

Comment 3

[Yaroslav]

Attachment: pk11mode.patch

Seems like memory leakage with pTemplate and pT2 not fixed yet.
I've made a patch that should fix this issue

Comment 4

[Anna Weine]

Do you mind submitting the patch using Phabricator? phabricator.services.mozilla.com/

Do you need any help with it?

Comment 5

[Yaroslav]

Attachment: WIP: Bug 1225123 - memory leakage fix

Comment 6

[Yaroslav]

(In reply to nkulatova from comment #4)

Do you mind submitting the patch using Phabricator? phabricator.services.mozilla.com/

Do you need any help with it?

This is my first contribution so I didn't know that Phabricator should be used.
Uploaded my changes.