1225129 - Strip environment variables for firefox-ui-tests

Status: RESOLVED WONTFIX

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As of now we keep all the environment variable of the slave nodes and pass them to each invocation of external commands. As result the the full environment gets printed out each time. This not only clutters the logs but could also leak sensitive data.

That's why we should only pass in a sub-set and only the necessary environment variables like for proxies (which is needed in SCL3).

Maja or Syd, one of you might also check that for the media tests.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I have investigated the handling of environment variables and I don't think that doing something here in the mozharness script is the right way to go. If we strip env variables we have to know which ones we have to retain. Those will be different per platform and it would be easy to miss something. Also because if a new one gets added for our CI slaves, we would have to update mozharness to accommodate that. Further only stripping the env variables for credentials would have the same effect. We will give a vector for attacks and if new credentials are being added via Jenkins those can easily be leaked in logs in case mozharness hasn't been updated across all branches!!

Lets close this bug as wontfix and instead get https://github.com/mozilla/mozmill-ci/issues/658 implemented.