1225142 - Add chrome software buttons on runtime

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Alexandre Poirot [:ochameau]]

Today, software buttons used in simulators are added via FXOS_SIMULATOR=1 build variable. But we are about to remove this as we will stop supporting b2g-desktop for simulators (bug 1210382).
But... we would still need these software buttons when running the simulators on top of mulet.
Simulators on top of mulet are passing -chrome chrome://b2g/content/shell.html,
that, to hide the browser UI which would be disturbing when run from WebIDE!
And we would still like to display the software buttons.
So it would be great to have a preference or any other runtime flag to enable them.

This prevent releasing 2.5+ simulators builds as we are now based on top of mulet for desktop.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Fabrice, I also flagged you as these modifications leak outside of just chrome/content/devtools.

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1aa2e8fd3c0d

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=66993a7d5c05

Comment 4

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/91ba3c43e5202cd733c7f0de3c22b290489a8a80
Bug 1225142 - Add software button on runtime to control it via a preference. r=fabrice,jryans

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/91ba3c43e520