Upgrade python selenium library in test requirements

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mdoglio, Assigned: mdoglio)

Tracking

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Upgrading to the latest version solved an issue I had running the webdriver tests on my machine.

Current: selenium==2.45.0
Latest: selenium==2.48.0

Changelog available here: https://github.com/SeleniumHQ/selenium/blob/d3e95e23ca47b8e82b814c4e92167cc7f91aad44/py/CHANGES#L1-L48
(Assignee)

Comment 1

3 years ago
Created attachment 8688005 [details]
MozReview Request: testing: upgrade selenium to 2.48.0 (bug 1225200); r=gps

testing: upgrade selenium to 2.48.0 (bug 1225200); r?gps
Attachment #8688005 - Flags: review?(gps)
(Assignee)

Comment 2

3 years ago
Created attachment 8688006 [details]
MozReview Request: testing: better describe webdriver tests skip reason; r=gps

testing: better describe webdriver tests skip reason; r?gps
Attachment #8688006 - Flags: review?(gps)

Updated

3 years ago
Attachment #8688005 - Flags: review?(gps) → review+

Comment 3

3 years ago
Comment on attachment 8688005 [details]
MozReview Request: testing: upgrade selenium to 2.48.0 (bug 1225200); r=gps

https://reviewboard.mozilla.org/r/25267/#review22761

::: ansible/roles/hg-web/tasks/main.yml:478
(Diff revision 1)
> -  notify: reread supervisor
> +  # notify: reread supervisor

Why?

Updated

3 years ago
Attachment #8688006 - Flags: review?(gps) → review+

Comment 4

3 years ago
Comment on attachment 8688006 [details]
MozReview Request: testing: better describe webdriver tests skip reason; r=gps

https://reviewboard.mozilla.org/r/25269/#review22763

::: testing/vcttesting/unittest.py:129
(Diff revision 1)
> -        except Exception:
> +        except Exception, e:

The comma syntax is deprecated and doesn't even work with Python 3. Use "except Exception as e:"
(Assignee)

Comment 5

3 years ago
Comment on attachment 8688005 [details]
MozReview Request: testing: upgrade selenium to 2.48.0 (bug 1225200); r=gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25267/diff/1-2/
(Assignee)

Comment 6

3 years ago
Comment on attachment 8688006 [details]
MozReview Request: testing: better describe webdriver tests skip reason; r=gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25269/diff/1-2/
(Assignee)

Comment 7

3 years ago
Comment on attachment 8688005 [details]
MozReview Request: testing: upgrade selenium to 2.48.0 (bug 1225200); r=gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25267/diff/2-3/
(Assignee)

Comment 8

3 years ago
Comment on attachment 8688006 [details]
MozReview Request: testing: better describe webdriver tests skip reason; r=gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25269/diff/2-3/
(Assignee)

Comment 9

3 years ago
https://reviewboard.mozilla.org/r/25267/#review22761

> Why?

I thought I shelved this one. I was developing with that line commented because of [bug 1225167](https://bugzilla.mozilla.org/show_bug.cgi?id=1225167)
(Assignee)

Comment 10

3 years ago
Comment on attachment 8688005 [details]
MozReview Request: testing: upgrade selenium to 2.48.0 (bug 1225200); r=gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25267/diff/3-4/
Attachment #8688005 - Attachment description: MozReview Request: testing: upgrade selenium to 2.48.0 (bug 1225200); r?gps → MozReview Request: testing: upgrade selenium to 2.48.0 (bug 1225200); r=gps
(Assignee)

Comment 11

3 years ago
Comment on attachment 8688006 [details]
MozReview Request: testing: better describe webdriver tests skip reason; r=gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25269/diff/3-4/
Attachment #8688006 - Attachment description: MozReview Request: testing: better describe webdriver tests skip reason; r?gps → MozReview Request: testing: better describe webdriver tests skip reason; r=gps
(Assignee)

Updated

3 years ago
Assignee: nobody → mdoglio
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.