If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Implement very simple request time logging

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
General
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: dylan, Assigned: dylan)

Tracking

Production

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
- store start_time in the request_cache at the start of a request (init_page should do)
- at the end of the request, syslog the time information out as "$request_url " . (time - $request_cache->{start_time})
- use this data when there are huge spikes in the webheads load graphs to figure out what's the worst requests.
(Assignee)

Updated

2 years ago
Summary: Implement very simple request timing logging → Implement very simple request time logging
(Assignee)

Comment 1

2 years ago
Created attachment 8688096 [details] [diff] [review]
1225214_1.patch

note: this is deployed to bugzilla-dev for additional testing. If you think it's safe I'd love for it to go out this week... of course we can always wait, but getting more data on request times would be good.
Attachment #8688096 - Flags: review?(dkl)
(Assignee)

Comment 2

2 years ago
Created attachment 8688114 [details] [diff] [review]
1225214_3.patch

It seems like I can't rely on the info from $cgi during _cleanup, but the envs are still good (this is only under bugzilla-dev's mod_perl, it seemed to work locally). Also no logging except under mod_perl.
Attachment #8688096 - Attachment is obsolete: true
Attachment #8688096 - Flags: review?(dkl)
Attachment #8688114 - Flags: review?(dkl)
(Assignee)

Comment 3

2 years ago
Comment on attachment 8688114 [details] [diff] [review]
1225214_3.patch

Review of attachment 8688114 [details] [diff] [review]:
-----------------------------------------------------------------

Never mind, as usual with bugzilla this will require a little more thought.
Attachment #8688114 - Flags: review?(dkl)
(Assignee)

Comment 4

2 years ago
Created attachment 8739150 [details] [diff] [review]
1225214_2.patch

Finally got around to doing this right.
Attachment #8688114 - Attachment is obsolete: true
Attachment #8739150 - Flags: review?(dkl)
Comment on attachment 8739150 [details] [diff] [review]
1225214_2.patch

Review of attachment 8739150 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8739150 - Flags: review?(dkl) → review+
(Assignee)

Comment 6

a year ago
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   dacce0f..f885e90  master -> master
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.