1225214 - Implement very simple request time logging

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

- store start_time in the request_cache at the start of a request (init_page should do)
- at the end of the request, syslog the time information out as "$request_url " . (time - $request_cache->{start_time})
- use this data when there are huge spikes in the webheads load graphs to figure out what's the worst requests.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1225214_1.patch

note: this is deployed to bugzilla-dev for additional testing. If you think it's safe I'd love for it to go out this week... of course we can always wait, but getting more data on request times would be good.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1225214_3.patch

It seems like I can't rely on the info from $cgi during _cleanup, but the envs are still good (this is only under bugzilla-dev's mod_perl, it seemed to work locally). Also no logging except under mod_perl.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8688114 [details] [diff] [review]
1225214_3.patch

Review of attachment 8688114 [details] [diff] [review]:
-----------------------------------------------------------------

Never mind, as usual with bugzilla this will require a little more thought.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1225214_2.patch

Finally got around to doing this right.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8739150 [details] [diff] [review]
1225214_2.patch

Review of attachment 8739150 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 6

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   dacce0f..f885e90  master -> master