Closed
Bug 1225268
Opened 9 years ago
Closed 9 years ago
page load throws "Error: $scope.fieldChoices[field].choices[value] is undefined" on console when field filter set
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: camd)
Details
this is benign and I'm pretty sure it's just a race condition.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → cdawson
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Oh crikey! I accidentally committed this change directly to master! (though I don't think there's any harm, tbh) This change is really benign and I've tested around it thoroughly (not much to test).
The issue was IF you had a field filter in the query string, and it was one that was a CHOICE in the list of filters (like failure_classification) then it'll still do the correct filtering, but you'll get an exception on the console. This just avoids the exception.
Ed: would you posthumously take a look at https://github.com/mozilla/treeherder/commit/18ddac64d7ec9775bdfe74474a75378051986a61
please? Dang, sorry about this. I'm happy to revert it if you don't feel good about the change.
Flags: needinfo?(emorley)
Comment 2•9 years ago
|
||
lgtm, thank you for the fix :-)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(emorley)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•