1225340 - Followup of bug 1223806: Refine nullity check macros in BluetoothServiceBluedroid

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Per bug 1223806 comment 12 change, macros in [1] should be revised to match each method's requirement.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp#39

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Refine nullity check macros in BluetoothServiceBluedroid

Comment 2

[Ben Tian (inactive)]

Attachment: Patch 1 (v2): Refine nullity check macros in BluetoothServiceBluedroid

Rebase on the latest m-c.

Comment 3

[Ben Tian (inactive)]

Attachment: Patch 1 (v3): Refine nullity check macros in BluetoothServiceBluedroid

Restore GATT macro part.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8689875 [details] [diff] [review]
Patch 1 (v3): Refine nullity check macros in BluetoothServiceBluedroid

Review of attachment 8689875 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
@@ +35,5 @@
>  #include "mozilla/StaticMutex.h"
>  #include "mozilla/StaticPtr.h"
>  #include "mozilla/unused.h"
>  
> +#define ENSURE_BLUETOOTH_ENABLED(runnable, result)                     \

Maybe |ENSURE_BLUETOOTH_IS_ENABLED| (?) That sounds more natural to me.

Comment 5

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Refine nullity check macros in BluetoothServiceBluedroid, r=tzimmermann

Revise per reviewer's comment.

Comment 6

[Ben Tian (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6001082399eb

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/f92df94073a3

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f92df94073a3