Followup of bug 1223806: Refine nullity check macros in BluetoothServiceBluedroid
RESOLVED
FIXED
in Firefox 45
Status
People
(Reporter: ben.tian, Assigned: ben.tian)
Tracking
Firefox Tracking Flags
(firefox45 fixed)
Details
Attachments
(1 attachment, 3 obsolete attachments)
Per bug 1223806 comment 12 change, macros in [1] should be revised to match each method's requirement. [1] https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp#39
|
(Assignee) | |
Updated•3 years ago
|
||
Summary: Refine nullity check macros in BluetoothServiceBluedroid → Followup of bug 1223806: Refine nullity check macros in BluetoothServiceBluedroid
|
|
(Assignee) | |
Comment 1•3 years ago
|
||
Created attachment 8688215 [details] [diff] [review] Patch 1 (v1): Refine nullity check macros in BluetoothServiceBluedroid
Assignee: nobody → btian
|
|
(Assignee) | |
Comment 2•3 years ago
|
||
Created attachment 8689872 [details] [diff] [review] Patch 1 (v2): Refine nullity check macros in BluetoothServiceBluedroid Rebase on the latest m-c.
Attachment #8688215 -
Attachment is obsolete: true
|
|
(Assignee) | |
Comment 3•3 years ago
|
||
Created attachment 8689875 [details] [diff] [review] Patch 1 (v3): Refine nullity check macros in BluetoothServiceBluedroid Restore GATT macro part.
Attachment #8689872 -
Attachment is obsolete: true
Attachment #8689875 -
Flags: review?(tzimmermann)
|
||
Comment 4•3 years ago
|
||
Comment on attachment 8689875 [details] [diff] [review] Patch 1 (v3): Refine nullity check macros in BluetoothServiceBluedroid Review of attachment 8689875 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp @@ +35,5 @@ > #include "mozilla/StaticMutex.h" > #include "mozilla/StaticPtr.h" > #include "mozilla/unused.h" > > +#define ENSURE_BLUETOOTH_ENABLED(runnable, result) \ Maybe |ENSURE_BLUETOOTH_IS_ENABLED| (?) That sounds more natural to me.
Attachment #8689875 -
Flags: review?(tzimmermann) → review+
|
|
(Assignee) | |
Comment 5•3 years ago
|
||
Created attachment 8690622 [details] [diff] [review] [final] Patch 1: Refine nullity check macros in BluetoothServiceBluedroid, r=tzimmermann Revise per reviewer's comment.
Attachment #8689875 -
Attachment is obsolete: true
|
|
(Assignee) | |
Comment 6•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6001082399eb
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f92df94073a3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
You need to log in
before you can comment on or make changes to this bug.
Description
•