Closed
Bug 1225340
Opened 10 years ago
Closed 10 years ago
Followup of bug 1223806: Refine nullity check macros in BluetoothServiceBluedroid
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox45 fixed)
RESOLVED
FIXED
2.6 S2 - 12/4
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: ben.tian, Assigned: ben.tian)
References
Details
Attachments
(1 file, 3 obsolete files)
Per bug 1223806 comment 12 change, macros in [1] should be revised to match each method's requirement.
[1] https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp#39
Assignee | ||
Updated•10 years ago
|
Summary: Refine nullity check macros in BluetoothServiceBluedroid → Followup of bug 1223806: Refine nullity check macros in BluetoothServiceBluedroid
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → btian
Assignee | ||
Comment 2•10 years ago
|
||
Rebase on the latest m-c.
Attachment #8688215 -
Attachment is obsolete: true
Assignee | ||
Comment 3•10 years ago
|
||
Restore GATT macro part.
Attachment #8689872 -
Attachment is obsolete: true
Attachment #8689875 -
Flags: review?(tzimmermann)
Comment 4•10 years ago
|
||
Comment on attachment 8689875 [details] [diff] [review]
Patch 1 (v3): Refine nullity check macros in BluetoothServiceBluedroid
Review of attachment 8689875 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
@@ +35,5 @@
> #include "mozilla/StaticMutex.h"
> #include "mozilla/StaticPtr.h"
> #include "mozilla/unused.h"
>
> +#define ENSURE_BLUETOOTH_ENABLED(runnable, result) \
Maybe |ENSURE_BLUETOOTH_IS_ENABLED| (?) That sounds more natural to me.
Attachment #8689875 -
Flags: review?(tzimmermann) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Revise per reviewer's comment.
Attachment #8689875 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
Comment 8•10 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
You need to log in
before you can comment on or make changes to this bug.
Description
•