1225351 - Don't enter job selection mode when list of runnable jobs is empty

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Alice Scarpa [:adusca]]

From bug 1194830 comment #30:

> One additional change that can be done in a followup bug (could you file?):
> When the "No additional jobs found" message is shown (eg before the fetch
> task was run on stage), the show/hide toggle on the push action menu still
> gets changed - which means the user has to choose "Hide ..." then "show ..."
> to try again.

Comment 1

[Kalpesh Krishna [:martianwars]]

Hi Alice,
I fished around a bit, but couldn't really understand the relevant parts of Treeherder here. If you could tell me which parts of the code are relevant here, I could get started and hopefully give a shot at this by Tuesday :)

Comment 2

[Alice Scarpa [:adusca]]

This bug happens when you click on "Add new jobs" and no runnable jobs are available. You can see this happening on gaia-try [1]. When you click on "Add new jobs", a message shows up saying "No new jobs available", but when you go to the menu again the item that shows up is "Hide runnable jobs", which doesn't make a lot of sense.

The buttons are defined in [2]. You can see that what controls which message shows up is resultset.isRunnableVisible, so you can find out where this gets set by searching for "isRunnableVisible".

[1]  https://treeherder.mozilla.org/#/jobs?repo=gaia-try
[2]  https://github.com/mozilla/treeherder/blob/c06ba00cd6c8e9eca9fe93554956bf132674d464/ui/partials/main/thActionButton.html#L18

Comment 3

[Kalpesh Krishna [:martianwars]]

Attachment: Fixing the isRunnableVisible toggle part

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8698646 [details] [review]
Fixing the isRunnableVisible toggle part

Cameron knows the UI much better than I, and I'm on vacation now until 4th Jan, so switching the review to him :-)

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8698646 [details] [review]
Fixing the isRunnableVisible toggle part

This fix looks good to me.  thank you!

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9768db8bdbbf62ac46b39cdc30865ff1d2a2f4a3
Bug 1225351 - Don't enter job selection mode when list of runnable jobs is empty. r=adusca

https://github.com/mozilla/treeherder/commit/4b91dfefe9e327440530f24d0990fb5e5c4c2b82
Merge pull request #1207 from martiansideofthemoon/my-code-fix

Bug 1225351 - Don't enter job selection mode when list of runnable jo…

Comment 7

[Cameron Dawson [:camd]]

I tested this and it works well.  Thanks again!

Comment 8

[Kalpesh Krishna [:martianwars]]

Thank you camd :) . Any good bug to work on next, adusca?

Comment 9

[Alice Scarpa [:adusca]]

I'm sorry, I don't have any bug suggestions. Since you are pretty active on IRC, I believe it would be better to ask there. That way a lot of people would be able to offer suggestions :-)