Closed Bug 1225357 Opened 4 years ago Closed 4 years ago

Convert toolkit tests to use asyncOpen2

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → mozilla
Blocks: 1182535
Status: NEW → ASSIGNED
Summary: Use channel.asyncOpen2 in toolkit/components/passwordmgr/test/test_prompt.html → Convert toolkit tests to use asyncOpen2
Comment on attachment 8707117 [details] [diff] [review]
bug_1225357_toolkit_tests_asyncopen2.patch

Review of attachment 8707117 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/mediasniffer/test/unit/test_mediasniffer.js
@@ +90,5 @@
>    httpserver.registerPathHandler(PATH, function(request, response) {
>      response.setHeader("Content-Type", tests[testRan].contentType, false);
>      response.bodyOutputStream.write(data, data.length);
>    });
> +  channel.asyncOpen2(listener);

Did you check that the listener doesn't use the received context since this will change from 'channel' to null?

::: toolkit/components/mediasniffer/test/unit/test_mediasniffer_ext.js
@@ +83,5 @@
>      do_test_finished();
>      return;
>    }
>    var channel = setupChannel("/");
> +  channel.asyncOpen2(listener);

Same here
Attachment #8707117 - Flags: review?(jonas) → review+
https://hg.mozilla.org/mozilla-central/rev/5026fb2da3f2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.