Closed Bug 1225358 Opened 9 years ago Closed 9 years ago

[TV][2.5] Highlight the icon of the app when navigating to an app

Categories

(Marketplace Graveyard :: General, defect, P1)

Product:
Marketplace Graveyard
Component:
General
Type:
defect

Tracking

(blocking-b2g:2.5+)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+

People

(Reporter: jyeh, Assigned: jyeh, Mentored)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file, 1 obsolete file)

jostw:josyeh/Marketplace/master/Bug1225358 > mozilla-b2g:master
62 bytes, text/x-github-pull-request
jj.evelyn
: review+
Details | Review 
      No description provided.
Assignee: nobody → jyeh
Blocks: TV_Marketplace_2.5
Status: NEW → ASSIGNED
Priority: -- → P2
Attached patch Bug 1225358 patch (obsolete) — — Splinter Review 

        Attachment #8689315 -
        Flags: review?(ehung)

    
    

    
  


  
I made one commit for this bug. Please review the commit with bug number 1225358 on it (i.e. commit 43d5d54).

Scale the app icon when navigating to an app.

        Attachment #8689315 -
        Attachment is obsolete: true

        Attachment #8689315 -
        Flags: review?(ehung)

        Attachment #8689404 -
        Flags: review?(ehung)

    
    

    
  
Comment on attachment 8689404 [details] [review]
jostw:josyeh/Marketplace/master/Bug1225358 > mozilla-b2g:master

I have no idea how the style being parsed at build time. Leave this review to Marketplace team. :/

Again, ni David and Lindsay to find a right person. Thank you!
Flags: needinfo?(lsaunders)
Flags: needinfo?(ddurst)

        Attachment #8689404 -
        Flags: review?(ehung)
Mentor: dspasovski
Flags: needinfo?(lsaunders)
Flags: needinfo?(ddurst)

    
    

    
  
Comment on attachment 8689404 [details] [review]
jostw:josyeh/Marketplace/master/Bug1225358 > mozilla-b2g:master

Hi Davor,

There is one commit for this bug (i.e. 489e5ee) and I have described them at https://bugzilla.mozilla.org/show_bug.cgi?id=1225358#c2.

Can you help me reviewing this? Thanks!

        Attachment #8689404 -
        Flags: review?(dspasovski)

    
  
blocking-b2g: --- → 2.5+
Whiteboard: [ft:conndevices]

    
  
Priority: P2 → P1

    
    

    
  
Comment on attachment 8689404 [details] [review]
jostw:josyeh/Marketplace/master/Bug1225358 > mozilla-b2g:master

robberstamp r+ because spasovski gave his r+ on Github.

        Attachment #8689404 -
        Flags: review?(dspasovski) → review+

    
    

    
  
Landed in marketplace-tv-front-end master

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/8d8a2c255bd6d983d6aa457f14b5f92699360ddc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: